* DECLARE_PCI_UNMAP_{ADDR,LEN} question
@ 2008-05-25 4:48 Marin Mitov
0 siblings, 0 replies; only message in thread
From: Marin Mitov @ 2008-05-25 4:48 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
Hi all,
In Documentation/DMA-mapping.txt is written:
NOTE: DO NOT put a semicolon at the end of the
DECLARE_PCI_UNMAP_{ADDR,LEN}() macro.
While the output of
grep DECLARE_PCI_UNMAP_ drivers/net/*
contains lines with and without semicolon:
drivers/net/acenic.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/acenic.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/acenic.h: DECLARE_PCI_UNMAP_LEN(maplen)
drivers/net/bnx2.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/bnx2.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/bnx2x.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/qla3xxx.h: DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/qla3xxx.h: DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/qla3xxx.h: DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/qla3xxx.h: DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/skge.h: DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/skge.h: DECLARE_PCI_UNMAP_LEN(maplen);
drivers/net/sky2.h: DECLARE_PCI_UNMAP_ADDR(mapaddr);
drivers/net/sky2.h: DECLARE_PCI_UNMAP_ADDR(maplen);
drivers/net/sky2.h: DECLARE_PCI_UNMAP_ADDR(data_size);
drivers/net/tg3.h: DECLARE_PCI_UNMAP_ADDR(mapping)
drivers/net/tg3.h: DECLARE_PCI_UNMAP_ADDR(mapping)
My question is:
Why one should NOT put semicolon at the end of the macro?
If it is _really_ important, should it be removed/patched?
Thank you for your answers.
Regards
Marin Mitov
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-25 4:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-25 4:48 DECLARE_PCI_UNMAP_{ADDR,LEN} question Marin Mitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®