mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Mike Galbraith <efault@gmx.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] let GROUP_SCHED depend on BROKEN
Date: Tue, 27 May 2008 11:58:30 +0300	[thread overview]
Message-ID: <20080527085830.GA20938@cs181133002.pp.htv.fi> (raw)

I know that this is controversial, for further background please see the
discussion in http://bugzilla.kernel.org/show_bug.cgi?id=10761

Facts:
- Bugzilla statistics
  (not counting duplicate bugs and bugs closed as INVALID):
  - 6 CPU scheduler regressions reported during 2.6.25-rc
    1 of them still open as of 2.6.26-rc4
  - 6 CPU scheduler regressions reported during 2.6.26-rc until now
    5 of them still open as of 2.6.26-rc4
  - at about half of the CPU scheduler regressions are related to
    group scheduling
- Peter Zijlstra said in Bugzilla bug #10761:
  > Adrian Bunk said:
  > The CPU scheduler is currently regressing horribly often, and half of the
  > regressions are in group scheduling.
  That is because group scheduling is horribly complex and was never
  feature complete - trying to solve that is high on my list of
  priorities.

My opinion:
- features that alter existing kernel functionality should (different
  from drivers for previously not supported hardware) be in a very good
  state before being offered in stable kernels
- Peter is wrong when he thinks that EXPERIMENTAL would somehow hide
  known-problematic features - in practice nearly everyone has to have 
  EXPERIMENTAL enabled (e.g. for some hardware driver)
- group scheduling already has a history of people accidentally enabling 
  it and then running into problems

I therefore suggest this patch to let GROUP_SCHED depend on BROKEN.

Once it is feature complete and then got the usual testing through
-next I'll have no objections against offering it again to users.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
c67cfbbb40895b72760865527dd1949631b1d183 diff --git a/init/Kconfig b/init/Kconfig
index d9526b5..564deba 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -333,7 +333,7 @@ config HAVE_UNSTABLE_SCHED_CLOCK
 
 config GROUP_SCHED
 	bool "Group CPU scheduler"
-	depends on EXPERIMENTAL
+	depends on BROKEN
 	default n
 	help
 	  This feature lets CPU scheduler recognize task groups and control CPU


             reply	other threads:[~2008-05-27  9:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27  8:58 Adrian Bunk [this message]
2008-05-27  9:47 ` Mike Galbraith
2008-05-27 10:04   ` Mike Galbraith
2008-05-27 10:26   ` Adrian Bunk
2008-05-27 10:28     ` Alan Cox
2008-05-27 11:27     ` Mike Galbraith
2008-05-27 11:47 ` Peter Zijlstra
2008-05-27 13:08   ` Adrian Bunk
2008-05-27 14:17     ` Peter Zijlstra
2008-05-27 17:30     ` Thomas Gleixner
2008-05-27 19:18       ` Adrian Bunk
2008-05-27 14:22 ` Ingo Molnar
2008-05-27 17:53   ` Adrian Bunk
2008-05-27 18:17     ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080527085830.GA20938@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®