mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch 2.6.26-rc4] add HAVE_CLK to Kconfig, for driver dependencies
@ 2008-05-29 18:56 David Brownell
  2008-06-05 13:54 ` Haavard Skinnemoen
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-05-29 18:56 UTC (permalink / raw)
  To: lkml; +Cc: Andrew Morton, Greg KH, Felipe Balbi

From: David Brownell <dbrownell@users.sourceforge.net>

This patch flags platforms as HAVE_CLK (or not) in Kconfig,
so that otherwise portable drivers which need those calls
can list that dependency.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
Something like this is a prerequisite for merging the musb_hdrc
driver, currently used on platforms including  Davinci, OMAP2430,
OMAP3xx ... and the discrete TUSB6010 chip, which doesn't have a
natural platform dependency.  (Used with OMAP 2420 in current
Nokia N8x0 tablets.)

 arch/Kconfig         |    7 +++++++
 arch/arm/Kconfig     |   13 +++++++++++++
 arch/avr32/Kconfig   |    1 +
 arch/powerpc/Kconfig |    1 +
 arch/sh/Kconfig      |    1 +
 5 files changed, 23 insertions(+)

--- a/arch/Kconfig	2008-04-29 12:29:26.000000000 -0700
+++ b/arch/Kconfig	2008-05-29 11:33:32.000000000 -0700
@@ -39,3 +39,10 @@ config HAVE_KRETPROBES
 
 config HAVE_DMA_ATTRS
 	def_bool n
+
+config HAVE_CLK
+	def_bool n
+	help
+	  The <linux/clk.h> calls support software clock gating and
+	  thus are a key power management tool on many systems.
+
--- a/arch/arm/Kconfig	2008-05-27 15:38:15.000000000 -0700
+++ b/arch/arm/Kconfig	2008-05-29 11:38:24.000000000 -0700
@@ -183,12 +183,14 @@ choice
 config ARCH_AAEC2000
 	bool "Agilent AAEC-2000 based"
 	select ARM_AMBA
+	select HAVE_CLK
 	help
 	  This enables support for systems based on the Agilent AAEC-2000
 
 config ARCH_INTEGRATOR
 	bool "ARM Ltd. Integrator family"
 	select ARM_AMBA
+	select HAVE_CLK
 	select ICST525
 	help
 	  Support for ARM's Integrator platform.
@@ -196,6 +198,7 @@ config ARCH_INTEGRATOR
 config ARCH_REALVIEW
 	bool "ARM Ltd. RealView family"
 	select ARM_AMBA
+	select HAVE_CLK
 	select ICST307
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
@@ -206,6 +209,7 @@ config ARCH_VERSATILE
 	bool "ARM Ltd. Versatile family"
 	select ARM_AMBA
 	select ARM_VIC
+	select HAVE_CLK
 	select ICST307
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
@@ -215,6 +219,7 @@ config ARCH_VERSATILE
 config ARCH_AT91
 	bool "Atmel AT91"
 	select GENERIC_GPIO
+	select HAVE_CLK
 	select HAVE_GPIO_LIB
 	help
 	  This enables support for systems based on the Atmel AT91RM9200,
@@ -255,6 +260,7 @@ config ARCH_EP93XX
 	select ARM_AMBA
 	select ARM_VIC
 	select GENERIC_GPIO
+	select HAVE_CLK
 	select HAVE_GPIO_LIB
 	help
 	  This enables support for the Cirrus EP93xx series of CPUs.
@@ -360,6 +366,7 @@ config ARCH_NS9XXX
 	select GENERIC_GPIO
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
+	select HAVE_CLK
 	help
 	  Say Y here if you intend to run this kernel on a NetSilicon NS9xxx
 	  System.
@@ -386,6 +393,7 @@ config ARCH_ORION5X
 
 config ARCH_PNX4008
 	bool "Philips Nexperia PNX4008 Mobile"
+	select HAVE_CLK
 	help
 	  This enables support for Philips PNX4008 mobile platform.
 
@@ -394,6 +402,7 @@ config ARCH_PXA
 	depends on MMU
 	select ARCH_MTD_XIP
 	select GENERIC_GPIO
+	select HAVE_CLK
 	select HAVE_GPIO_LIB
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
@@ -423,6 +432,7 @@ config ARCH_SA1100
 	select GENERIC_GPIO
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
+	select HAVE_CLK
 	select TICK_ONESHOT
 	select HAVE_GPIO_LIB
 	help
@@ -431,6 +441,7 @@ config ARCH_SA1100
 config ARCH_S3C2410
 	bool "Samsung S3C2410, S3C2412, S3C2413, S3C2440, S3C2442, S3C2443"
 	select GENERIC_GPIO
+	select HAVE_CLK
 	help
 	  Samsung S3C2410X CPU based systems, such as the Simtec Electronics
 	  BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
@@ -458,12 +469,14 @@ config ARCH_DAVINCI
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
 	select GENERIC_GPIO
+	select HAVE_CLK
 	help
 	  Support for TI's DaVinci platform.
 
 config ARCH_OMAP
 	bool "TI OMAP"
 	select GENERIC_GPIO
+	select HAVE_CLK
 	select HAVE_GPIO_LIB
 	select GENERIC_TIME
 	select GENERIC_CLOCKEVENTS
--- a/arch/avr32/Kconfig	2008-05-29 11:40:42.000000000 -0700
+++ b/arch/avr32/Kconfig	2008-05-29 11:41:08.000000000 -0700
@@ -10,6 +10,7 @@ config AVR32
 	# With EMBEDDED=n, we get lots of stuff automatically selected
 	# that we usually don't need on AVR32.
 	select EMBEDDED
+	select HAVE_CLK
 	select HAVE_OPROFILE
 	select HAVE_KPROBES
 	help
--- a/arch/powerpc/Kconfig	2008-05-29 11:45:49.000000000 -0700
+++ b/arch/powerpc/Kconfig	2008-05-29 11:45:57.000000000 -0700
@@ -812,6 +812,7 @@ source "crypto/Kconfig"
 config PPC_CLOCK
 	bool
 	default n
+	select HAVE_CLK
 
 config PPC_LIB_RHEAP
 	bool
--- a/arch/sh/Kconfig	2008-05-29 11:42:32.000000000 -0700
+++ b/arch/sh/Kconfig	2008-05-29 11:42:42.000000000 -0700
@@ -8,6 +8,7 @@ mainmenu "Linux/SuperH Kernel Configurat
 config SUPERH
 	def_bool y
 	select EMBEDDED
+	select HAVE_CLK
 	select HAVE_IDE
 	select HAVE_OPROFILE
 	help

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.26-rc4] add HAVE_CLK to Kconfig, for driver dependencies
  2008-05-29 18:56 [patch 2.6.26-rc4] add HAVE_CLK to Kconfig, for driver dependencies David Brownell
@ 2008-06-05 13:54 ` Haavard Skinnemoen
  0 siblings, 0 replies; 2+ messages in thread
From: Haavard Skinnemoen @ 2008-06-05 13:54 UTC (permalink / raw)
  To: David Brownell; +Cc: lkml, Andrew Morton, Greg KH, Felipe Balbi

David Brownell <david-b@pacbell.net> wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> This patch flags platforms as HAVE_CLK (or not) in Kconfig,
> so that otherwise portable drivers which need those calls
> can list that dependency.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Great idea! This will allow us to clean up some of the dependency mess
in the shared AVR32/AT91 drivers and get better compile-testing
coverage.

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-05 13:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-29 18:56 [patch 2.6.26-rc4] add HAVE_CLK to Kconfig, for driver dependencies David Brownell
2008-06-05 13:54 ` Haavard Skinnemoen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®