mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check
@ 2008-05-31 16:15 Oleg Nesterov
  2008-06-03 21:59 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2008-05-31 16:15 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Roland McGrath, linux-kernel

fae5fa44f1fd079ffbed8e0add929dd7bbd1347f changed do_signal_stop() to check
SIGNAL_UNKILLABLE, this wasn't needed. If signal_group_exit() == F, the
signal sent to SIGNAL_UNKILLABLE task must be already filtered out by the
caller, get_signal_to_deliver(). And if signal_group_exit() == T we are not
going to stop.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 26-rc2/kernel/signal.c~2_DSS_KILL_UNKILLABLE_CHECK	2008-05-31 14:54:32.000000000 +0400
+++ 26-rc2/kernel/signal.c	2008-05-31 16:03:39.000000000 +0400
@@ -1649,8 +1649,7 @@ static int do_signal_stop(int signr)
 	} else {
 		struct task_struct *t;
 
-		if (unlikely((sig->flags & (SIGNAL_STOP_DEQUEUED | SIGNAL_UNKILLABLE))
-					 != SIGNAL_STOP_DEQUEUED) ||
+		if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
 		    unlikely(signal_group_exit(sig)))
 			return 0;
 		/*


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check
  2008-05-31 16:15 [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check Oleg Nesterov
@ 2008-06-03 21:59 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2008-06-03 21:59 UTC (permalink / raw)
  To: Oleg Nesterov; +Cc: Andrew Morton, linux-kernel

Acked-by: Roland McGrath <roland@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-03 22:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-31 16:15 [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check Oleg Nesterov
2008-06-03 21:59 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®