From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: hch@infradead.org, linux-fsdevel@vger.kernel.org,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [patch 8/8] vfs: create file_remove_suid() helper
Date: Mon, 2 Jun 2008 02:05:09 -0400 [thread overview]
Message-ID: <20080602060509.GA27519@infradead.org> (raw)
In-Reply-To: <E1K2uQk-0001dO-G7@pomaz-ex.szeredi.hu>
On Sun, Jun 01, 2008 at 10:45:30PM +0200, Miklos Szeredi wrote:
> Which means, that that pointer dereference will be done once instead
> of in each caller, no? It's a gain (albeit a small one) is in code
> cleanliness, and possibly in generated code size.
Again, it doesn't make anyhing simpler. It might be a cleanup at best.
I don't really care too much about this one because we could easily
change it back in case a caller appear that just has the inode, but the
tone you set here defintively doesn't help getting these trivial patches
without real gain in :)
next prev parent reply other threads:[~2008-06-02 6:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 11:32 [patch 0/8] vfs: more cleanups and fixes Miklos Szeredi
2008-05-29 11:32 ` [patch 1/8] vfs: dcache cleanups Miklos Szeredi
2008-05-29 12:23 ` Matthew Wilcox
2008-05-31 8:18 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 2/8] vfs: fix sys_getcwd for detached mounts Miklos Szeredi
2008-05-31 8:20 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 3/8] Make d_path() consistent across mount operations Miklos Szeredi
2008-05-31 8:22 ` Christoph Hellwig
2008-06-01 20:38 ` Miklos Szeredi
2008-06-02 5:55 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 4/8] nfsd: rename MAY_ flags Miklos Szeredi
2008-05-29 12:47 ` Christoph Hellwig
2008-05-29 14:02 ` Miklos Szeredi
2008-05-29 20:40 ` J. Bruce Fields
2008-05-30 7:36 ` Christoph Hellwig
2008-05-30 9:07 ` Miklos Szeredi
2008-05-30 9:53 ` Miklos Szeredi
2008-05-30 20:12 ` J. Bruce Fields
2008-05-29 11:32 ` [patch 5/8] vfs: annotate permission operations Miklos Szeredi
2008-05-31 8:23 ` Christoph Hellwig
2008-05-29 11:32 ` [patch 6/8] Factor out sysctl pathname code Miklos Szeredi
2008-05-31 8:27 ` Christoph Hellwig
2008-06-03 13:34 ` Stephen Smalley
2008-05-29 11:32 ` [patch 7/8] vfs: clean up getattr API Miklos Szeredi
2008-05-29 11:32 ` [patch 8/8] vfs: create file_remove_suid() helper Miklos Szeredi
2008-05-31 8:29 ` Christoph Hellwig
2008-06-01 20:45 ` Miklos Szeredi
2008-06-02 6:05 ` Christoph Hellwig [this message]
2008-06-02 7:06 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602060509.GA27519@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®