From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <dada1@cosmosbay.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] x86: Extend percpu ops to 64 bit
Date: Tue, 03 Jun 2008 17:30:20 -0700 [thread overview]
Message-ID: <20080604003019.299510000@polaris-admin.engr.sgi.com> (raw)
In-Reply-To: <20080604003018.538497000@polaris-admin.engr.sgi.com>
[-- Attachment #1: zero_based_percpu_64bit --]
[-- Type: text/plain, Size: 3858 bytes --]
* x86 percpu ops now will work on 64 bit too, so add the missing 8 byte cases.
* Add a few atomic ops that will be useful in the future:
x86_xchg_percpu()
x86_cmpxchg_percpu().
x86_inc_percpu() - Increment by one can generate more efficient
x86_dec_percpu() instructions and inc/dec will be supported by
cpu ops later.
* Use per_cpu_var() instead of per_cpu__##xxx.
Based on linux-2.6.tip
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Mike Travis <travis@sgi.com>
---
include/asm-x86/percpu.h | 83 ++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 78 insertions(+), 5 deletions(-)
--- linux-2.6.tip.orig/include/asm-x86/percpu.h
+++ linux-2.6.tip/include/asm-x86/percpu.h
@@ -108,6 +108,11 @@ do { \
: "+m" (var) \
: "ri" ((T__)val)); \
break; \
+ case 8: \
+ asm(op "q %1,"__percpu_seg"%0" \
+ : "+m" (var) \
+ : "ri" ((T__)val)); \
+ break; \
default: __bad_percpu_size(); \
} \
} while (0)
@@ -131,16 +136,84 @@ do { \
: "=r" (ret__) \
: "m" (var)); \
break; \
+ case 8: \
+ asm(op "q "__percpu_seg"%1,%0" \
+ : "=r" (ret__) \
+ : "m" (var)); \
+ break; \
default: __bad_percpu_size(); \
} \
ret__; \
})
-#define x86_read_percpu(var) percpu_from_op("mov", per_cpu__##var)
-#define x86_write_percpu(var, val) percpu_to_op("mov", per_cpu__##var, val)
-#define x86_add_percpu(var, val) percpu_to_op("add", per_cpu__##var, val)
-#define x86_sub_percpu(var, val) percpu_to_op("sub", per_cpu__##var, val)
-#define x86_or_percpu(var, val) percpu_to_op("or", per_cpu__##var, val)
+#define percpu_addr_op(op, var) \
+({ \
+ switch (sizeof(var)) { \
+ case 1: \
+ asm(op "b "__percpu_seg"%0" \
+ : : "m"(var)); \
+ break; \
+ case 2: \
+ asm(op "w "__percpu_seg"%0" \
+ : : "m"(var)); \
+ break; \
+ case 4: \
+ asm(op "l "__percpu_seg"%0" \
+ : : "m"(var)); \
+ break; \
+ case 8: \
+ asm(op "q "__percpu_seg"%0" \
+ : : "m"(var)); \
+ break; \
+ default: __bad_percpu_size(); \
+ } \
+})
+
+#define percpu_cmpxchg_op(var, old, new) \
+({ \
+ typeof(var) prev; \
+ switch (sizeof(var)) { \
+ case 1: \
+ asm("cmpxchgb %b1, "__percpu_seg"%2" \
+ : "=a"(prev) \
+ : "q"(new), "m"(var), "0"(old) \
+ : "memory"); \
+ break; \
+ case 2: \
+ asm("cmpxchgw %w1, "__percpu_seg"%2" \
+ : "=a"(prev) \
+ : "r"(new), "m"(var), "0"(old) \
+ : "memory"); \
+ break; \
+ case 4: \
+ asm("cmpxchgl %k1, "__percpu_seg"%2" \
+ : "=a"(prev) \
+ : "r"(new), "m"(var), "0"(old) \
+ : "memory"); \
+ break; \
+ case 8: \
+ asm("cmpxchgq %1, "__percpu_seg"%2" \
+ : "=a"(prev) \
+ : "r"(new), "m"(var), "0"(old) \
+ : "memory"); \
+ break; \
+ default: \
+ __bad_percpu_size(); \
+ } \
+ return prev; \
+})
+
+#define x86_read_percpu(var) percpu_from_op("mov", per_cpu_var(var))
+#define x86_write_percpu(var, val) percpu_to_op("mov", per_cpu_var(var), val)
+#define x86_add_percpu(var, val) percpu_to_op("add", per_cpu_var(var), val)
+#define x86_sub_percpu(var, val) percpu_to_op("sub", per_cpu_var(var), val)
+#define x86_inc_percpu(var) percpu_addr_op("inc", per_cpu_var(var))
+#define x86_dec_percpu(var) percpu_addr_op("dec", per_cpu_var(var))
+#define x86_or_percpu(var, val) percpu_to_op("or", per_cpu_var(var), val)
+#define x86_xchg_percpu(var, val) percpu_to_op("xchg", per_cpu_var(var), val)
+#define x86_cmpxchg_percpu(var, old, new) \
+ percpu_cmpxchg_op(per_cpu_var(var), old, new)
+
#endif /* !__ASSEMBLY__ */
#endif /* !CONFIG_X86_64 */
--
next prev parent reply other threads:[~2008-06-04 0:31 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 0:30 [PATCH 0/4] percpu: Optimize percpu accesses Mike Travis
2008-06-04 0:30 ` [PATCH 1/4] Zero based percpu: Infrastructure to rebase the per cpu area to zero Mike Travis
2008-06-10 10:06 ` Ingo Molnar
2008-06-04 0:30 ` Mike Travis [this message]
2008-06-10 10:04 ` [PATCH 2/4] x86: Extend percpu ops to 64 bit Ingo Molnar
2008-06-04 0:30 ` [PATCH 3/4] x86_64: Fold pda into per cpu area Mike Travis
2008-06-04 12:59 ` Jeremy Fitzhardinge
2008-06-04 13:48 ` Mike Travis
2008-06-04 13:58 ` Jeremy Fitzhardinge
2008-06-04 14:17 ` Mike Travis
2008-06-09 23:18 ` Christoph Lameter
2008-06-05 10:22 ` [crash, bisected] " Ingo Molnar
2008-06-05 16:02 ` Mike Travis
2008-06-06 8:29 ` Jeremy Fitzhardinge
2008-06-06 13:15 ` Mike Travis
2008-06-18 5:34 ` Jeremy Fitzhardinge
2008-06-10 21:31 ` Mike Travis
2008-06-18 17:36 ` Jeremy Fitzhardinge
2008-06-18 18:17 ` Mike Travis
2008-06-18 18:33 ` Ingo Molnar
2008-06-18 19:33 ` Jeremy Fitzhardinge
[not found] ` <48596893.4040908@sgi.com>
[not found] ` <485AADAC.3070301@sgi.com>
[not found] ` <485AB78B.5090904@goop.org>
[not found] ` <485AC120.6010202@sgi.com>
[not found] ` <485AC5D4.6040302@goop.org>
[not found] ` <485ACA8F.10006@sgi.com>
[not found] ` <485ACD92.8050109@sgi.com>
2008-06-19 21:35 ` Jeremy Fitzhardinge
2008-06-19 21:54 ` Jeremy Fitzhardinge
2008-06-19 22:13 ` Mike Travis
2008-06-19 22:21 ` Jeremy Fitzhardinge
2008-06-30 17:49 ` Mike Travis
2008-06-19 22:23 ` Jeremy Fitzhardinge
[not found] ` <485BDB04.4090709@sgi.com>
2008-06-20 17:25 ` Jeremy Fitzhardinge
2008-06-20 17:48 ` Christoph Lameter
2008-06-20 18:30 ` Mike Travis
2008-06-20 18:40 ` Jeremy Fitzhardinge
2008-06-20 18:37 ` Jeremy Fitzhardinge
2008-06-20 18:51 ` Christoph Lameter
2008-06-20 19:04 ` Jeremy Fitzhardinge
2008-06-20 19:21 ` H. Peter Anvin
2008-06-20 19:43 ` Eric W. Biederman
2008-06-20 20:04 ` Mike Travis
2008-06-20 20:37 ` Christoph Lameter
2008-06-20 19:06 ` Mike Travis
2008-06-20 20:25 ` Eric W. Biederman
2008-06-20 20:55 ` Christoph Lameter
2008-06-23 16:55 ` Mike Travis
2008-06-23 17:33 ` Jeremy Fitzhardinge
2008-06-23 18:04 ` Mike Travis
2008-06-23 18:36 ` Mike Travis
2008-06-23 19:41 ` Jeremy Fitzhardinge
2008-06-24 0:02 ` Mike Travis
2008-06-30 17:07 ` Mike Travis
2008-06-30 17:18 ` H. Peter Anvin
2008-06-30 17:57 ` Mike Travis
2008-06-30 20:50 ` Eric W. Biederman
2008-06-30 21:08 ` Jeremy Fitzhardinge
2008-07-01 8:40 ` Eric W. Biederman
2008-07-01 16:27 ` Jeremy Fitzhardinge
2008-07-01 16:55 ` Mike Travis
2008-07-01 16:56 ` H. Peter Anvin
2008-07-01 17:26 ` Jeremy Fitzhardinge
2008-07-01 20:40 ` Eric W. Biederman
2008-07-01 21:10 ` Jeremy Fitzhardinge
2008-07-01 21:39 ` Eric W. Biederman
2008-07-01 21:52 ` Jeremy Fitzhardinge
2008-07-02 0:20 ` H. Peter Anvin
2008-07-02 1:15 ` Mike Travis
2008-07-02 1:32 ` Eric W. Biederman
2008-07-02 1:51 ` Mike Travis
2008-07-02 2:50 ` Eric W. Biederman
2008-07-02 1:40 ` H. Peter Anvin
2008-07-02 1:44 ` Mike Travis
2008-07-02 1:45 ` H. Peter Anvin
2008-07-02 1:55 ` Mike Travis
2008-07-02 22:50 ` Mike Travis
2008-07-03 4:34 ` Eric W. Biederman
2008-07-07 17:17 ` Mike Travis
2008-07-07 19:46 ` Eric W. Biederman
2008-07-08 18:21 ` Mike Travis
2008-07-08 23:36 ` Eric W. Biederman
2008-07-08 23:49 ` Jeremy Fitzhardinge
2008-07-09 14:39 ` Mike Travis
2008-07-25 20:06 ` Mike Travis
2008-07-25 20:12 ` Jeremy Fitzhardinge
2008-07-25 20:34 ` Mike Travis
2008-07-25 20:43 ` Jeremy Fitzhardinge
2008-07-25 21:05 ` Mike Travis
2008-07-09 14:37 ` Mike Travis
2008-07-09 22:38 ` Eric W. Biederman
2008-07-09 23:30 ` Mike Travis
2008-07-10 0:04 ` Eric W. Biederman
2008-07-02 2:01 ` H. Peter Anvin
2008-07-02 3:08 ` Eric W. Biederman
2008-07-01 21:11 ` Andi Kleen
2008-07-01 21:42 ` Eric W. Biederman
2008-07-01 18:41 ` Eric W. Biederman
2008-07-01 12:09 ` Mike Travis
2008-07-01 11:49 ` Mike Travis
2008-06-30 17:43 ` Jeremy Fitzhardinge
2008-06-04 0:30 ` [PATCH 4/4] x86: Replace xxx_pda() operations with x86_xx_percpu() Mike Travis
2008-06-09 13:03 ` Ingo Molnar
2008-06-09 16:08 ` Mike Travis
2008-06-09 17:36 ` Mike Travis
2008-06-09 18:20 ` Christoph Lameter
2008-06-09 23:29 ` Jeremy Fitzhardinge
2008-06-10 10:09 ` Ingo Molnar
2008-06-10 15:07 ` Mike Travis
2008-06-04 10:18 ` [PATCH] x86: collapse the various size-dependent percpu accessors together Jeremy Fitzhardinge
2008-06-04 10:45 ` Jeremy Fitzhardinge
2008-06-04 11:29 ` Ingo Molnar
2008-06-04 12:09 ` Jeremy Fitzhardinge
2008-06-10 17:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604003019.299510000@polaris-admin.engr.sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®