From: Pavel Machek <pavel@suse.cz>
To: "Éric Piel" <Eric.Piel@tremplin-utc.net>
Cc: Andrew Morton <akpm@osdl.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Yan Burman <burman.yan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
HWMON <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!
Date: Thu, 5 Jun 2008 01:03:26 +0200 [thread overview]
Message-ID: <20080604230326.GA30475@elf.ucw.cz> (raw)
In-Reply-To: <4846EBF5.2030406@tremplin-utc.net>
Hi!
> We haven't received any review for this driver since last week's post by
> Yan :-( That's why I'm adding explicitly as receivers of this email all
> the people who have reviewed the first two previous takes. Apologies for
> the possible multiple receptions.
>
> It would be _really really kind_ if some of you could take some time and
> comment (or simply ACK ;-) ) this code. It adds support for hardware
> which can be found in mostly every HP Compaq laptop less than three
> years old. It's quite worthy.
It looked pretty much okay on _very_ quick look.
> > 3) Makes it possible to power the device off.
But this part is what I don't understand. powering off does not seem
to belong there. Why can't you just use acpi to power down?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-06-04 23:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 12:05 [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Yan Burman
2008-06-04 19:24 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-04 20:58 ` Jean Delvare
2008-06-04 22:57 ` Éric Piel
2008-06-05 6:27 ` Jean Delvare
2008-06-04 23:05 ` Pavel Machek
2008-06-04 23:43 ` Éric Piel
2008-06-05 6:29 ` Jean Delvare
2008-06-05 9:38 ` [lm-sensors] " Jonathan Cameron
2008-06-05 20:34 ` Éric Piel
2008-06-05 22:27 ` Pau Oliva Fora
2008-06-06 14:24 ` Dmitry Torokhov
2008-06-06 15:29 ` Pau Oliva Fora
2008-06-06 14:56 ` Eric Piel
2008-06-06 15:30 ` Pau Oliva Fora
2008-06-06 8:51 ` Jonathan Cameron
2008-06-04 23:03 ` Pavel Machek [this message]
2008-06-04 23:29 ` Éric Piel
2008-06-05 1:06 ` Henrique de Moraes Holschuh
2008-06-05 8:19 ` Pavel Machek
2008-06-06 14:27 ` Dmitry Torokhov
2008-06-06 14:59 ` Eric Piel
2008-06-06 15:11 ` Dmitry Torokhov
2008-06-06 15:37 ` Pau Oliva Fora
2008-06-05 5:17 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Andrew Morton
2008-06-05 7:43 ` [lm-sensors] " Riku Voipio
2008-06-05 8:28 ` Eric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604230326.GA30475@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=Eric.Piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=burman.yan@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®