[PATCH] stacktrace: print_stack_trace() cleanup

[PATCH] stacktrace: print_stack_trace() cleanup

[Vegard Nossum]

From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Fri, 13 Jun 2008 10:05:26 +0200
Subject: [PATCH] stacktrace: print_stack_trace() cleanup

This admittedly doesn't have too many benefits, these are the two I can
think of: shorter code and better atomicity with regards to printk().

(It's been tested with the backtrace self-test code on i386 and x86_64.)

Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
 kernel/stacktrace.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index b71816e..2ee264b 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -11,14 +11,11 @@
 
 void print_stack_trace(struct stack_trace *trace, int spaces)
 {
-	int i, j;
+	int i;
 
 	for (i = 0; i < trace->nr_entries; i++) {
-		unsigned long ip = trace->entries[i];
-
-		for (j = 0; j < spaces + 1; j++)
-			printk(" ");
-		print_ip_sym(ip);
+		printk("%*c", 1 + spaces, ' ');
+		print_ip_sym(trace->entries[i]);
 	}
 }
 
-- 
1.5.4.1

Re: [PATCH] stacktrace: print_stack_trace() cleanup

[Ingo Molnar]

* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Fri, 13 Jun 2008 10:05:26 +0200
> Subject: [PATCH] stacktrace: print_stack_trace() cleanup
> 
> This admittedly doesn't have too many benefits, these are the two I 
> can think of: shorter code and better atomicity with regards to 
> printk().
> 
> (It's been tested with the backtrace self-test code on i386 and 
> x86_64.)

applied to tip/core/stacktrace - thanks Vegard. (I have hand-merged it 
as there were a few stacktrace changes in the stacktrace tree already, 
queued up for v2.6.27.)

	Ingo