Re: [PATCH] hdaps add support for various IBM thinkpads R61/T61/T61P

["Klaus S. Madsen" <ubuntu@hjernemadsen.org>]

On Fri, Jun 13, 2008 at 13:26:47 +0200, maximilian attems wrote:
> last missing hdaps ubuntu sync.
> add the ubuntu entries in alphabetical order.
> original authors below on Cc.
> 
> Cc: Klaus S. Madsen <ubuntu@hjernemadsen.org>
> Cc: Chuck Short <zulcss@ubuntu.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: maximilian attems <max@stro.at>
> ---
>  drivers/hwmon/hdaps.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
> index 26df06f..e07c712 100644
> --- a/drivers/hwmon/hdaps.c
> +++ b/drivers/hwmon/hdaps.c
> @@ -515,6 +515,7 @@ static struct dmi_system_id __initdata hdaps_whitelist[] = {
>  	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R50"),
>  	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R51"),
>  	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R52"),
> +	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R61"),
>  	HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad R61i"),
>  	HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T41p"),
>  	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T41"),
> @@ -523,6 +524,8 @@ static struct dmi_system_id __initdata hdaps_whitelist[] = {
>  	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T43"),
>  	HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T60"),
>  	HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T61"),
> +	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61"),
> +	HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61P"),
I would suspect that this part of the patch is unnecessary. It would be
strange if there are any T61's where the manufacturer is IBM, instead of
LENOVO, since the T60 is older and has the manufacturer listed as
LENOVO, and no entry exists for IBM.

But according to the comment at the top of the struct, the second line
(the T61P part) is unnecessary, as a T61p already would be matched by
the T61 line. 

-- 
Kind regards,
	Klaus S. Madsen