* [PATCH 2/2] workqueues: schedule_on_each_cpu: use flush_work()
@ 2008-06-13 14:28 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2008-06-13 14:28 UTC (permalink / raw)
To: Andrew Morton
Cc: Jarek Poplawski, Max Krasnyansky, Peter Zijlstra, linux-kernel
Change schedule_on_each_cpu() to use flush_work() instead of flush_workqueue(),
this way we don't wait for other work_struct's which can be queued meanwhile.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 26-rc2/kernel/workqueue.c~WQ_3_USE_FLUSH_WORK 2008-06-13 17:31:54.000000000 +0400
+++ 26-rc2/kernel/workqueue.c 2008-06-13 17:34:05.000000000 +0400
@@ -653,7 +653,8 @@ int schedule_on_each_cpu(work_func_t fun
set_bit(WORK_STRUCT_PENDING, work_data_bits(work));
__queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work);
}
- flush_workqueue(keventd_wq);
+ for_each_online_cpu(cpu)
+ flush_work(per_cpu_ptr(works, cpu));
put_online_cpus();
free_percpu(works);
return 0;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-13 14:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-13 14:28 [PATCH 2/2] workqueues: schedule_on_each_cpu: use flush_work() Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®