Re: [KERNEL 2.6.26-rc4] bugreport : pata_pcmcia with Sandisk Extreme III 8GB

[Komuro <komurojun-mbn@nifty.com>]

On Sat, 14 Jun 2008 03:20:41 -0400
Jeff Garzik <jeff@garzik.org> wrote:


After removing the 3-lines below in ata_eh_reset
the pata_pcmcia works properly.


-       spin_lock_irqsave(link->ap->lock, flags);
-       link->eh_info.serror = 0;
-       spin_unlock_irqrestore(link->ap->lock, flags);

Please fix this problem.

Best Regards
Komuro


> > 
> >>>>>> pcmcia: registering new device pcmcia1.1
> >>>>>> 1.1: GetNextTuple: No more items
> >>>>>> pata_pcmcia: probe of 1.1 failed with error -12
> > 
> > The patch "libata: kill hotplug related race condition"
> > introduced the pata_pcmcia error.
> > 
> > Please fix this problem.
> > 
> > 
> > Best Regards
> > Komuro
> > 
> >>> f046519fc85a8fdf6a058b4ac9d897cdee6f3e52 is first bad commit
> > commit f046519fc85a8fdf6a058b4ac9d897cdee6f3e52
> > Author: Tejun Heo <htejun@gmail.com>
> > Date:   Mon May 19 01:15:08 2008 +0900
> > 
> >     libata: kill hotplug related race condition
> >     
> >     Originally, whole reset processing was done while the port is frozen
> >     and SError was cleared during @postreset().  This had two race
> >     conditions.  1: hotplug could occur after reset but before SError is
> >     cleared and libata won't know about it.  2: hotplug could occur after
> >     all the reset is complete but before the port is thawed.  As all
> >     events are cleared on thaw, the hotplug event would be lost.
> 
> Interesting!  Thanks for the diagnosis...
> 
> 	Jeff
> 
> 
> 


-- 
Komuro <komurojun-mbn@nifty.com>