From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org, jaswinder@infradead.org
Subject: Re: [PATCH] ip2: use request_firmware()
Date: Mon, 16 Jun 2008 11:59:50 +0100 [thread overview]
Message-ID: <20080616115950.41bc65aa@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1213609751.26255.673.camel@pmac.infradead.org>
On Mon, 16 Jun 2008 10:49:11 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> Converted with help from Jaswinder Singh
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> ---
> drivers/char/Kconfig | 7 +
> drivers/char/ip2/fip_firm.h | 2149 ----------------------------------------
> drivers/char/ip2/ip2base.c | 5 +-
> drivers/char/ip2/ip2main.c | 45 +-
> firmware/Makefile | 1 +
> firmware/WHENCE | 10 +
> firmware/intelliport2.bin.ihex | 2147 +++++++++++++++++++++++++++++++++++++++
> 7 files changed, 2201 insertions(+), 2163 deletions(-)
> delete mode 100644 drivers/char/ip2/fip_firm.h
> create mode 100644 firmware/intelliport2.bin.ihex
Fine by me. I've not checked all the digits are correct but the rest of
the logic seems clean enough
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2008-06-16 11:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 9:49 David Woodhouse
2008-06-16 10:59 ` Alan Cox [this message]
2008-06-16 12:06 ` David Woodhouse
2008-06-16 20:02 ` Jeff Garzik
2008-06-16 19:56 ` Alan Cox
2008-06-16 20:05 ` Jeff Garzik
2008-06-16 19:58 ` Alan Cox
2008-06-16 20:21 ` Jeff Garzik
2008-06-16 20:21 ` Alan Cox
2008-06-16 21:39 ` Jeff Garzik
2008-06-16 21:34 ` Alan Cox
2008-06-16 22:01 ` David Woodhouse
2008-06-16 20:12 ` Jeff Garzik
2008-06-16 20:00 ` Alan Cox
2008-06-16 20:22 ` Jeff Garzik
2008-06-16 20:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616115950.41bc65aa@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®