mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, jaswinder@infradead.org
Subject: Re: [PATCH] ip2: use request_firmware()
Date: Mon, 16 Jun 2008 20:56:38 +0100	[thread overview]
Message-ID: <20080616205638.2e9930fe@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4856C6C8.6060506@garzik.org>

> > Acked-by: Alan Cox <alan@redhat.com>
> 
> Except for the part where the firmware is pointlessly separated from the 
> driver.
> 
> We do not need two parallel driver hierarchies, one for firmware, one 
> for C source.

It makes enormous sense to me that we split them up. I don't care about
or believe the gnewspeak about licensing some people spew on the issue
but as a simple practical consideration:

- I don't want to wade through a ton of hex when looking at the driver
- I don't gain anything but having a ton of hex in the driver files
- I'd rather the ip2 firmware was ultimately loaded and unloaded when
needed as it saves us a load of non-pageable RAM.
- The firmware is a separate piece of software run on a separate CPU on a
seperate box on a separate card.

So from purely technical perspectives I think the patch is a very good
one, and as the nearest thing we have to a serial maintainer it gets my
ack. The only thing they share is an agreed API over the ISA/PCI bus -
and that isn't defined by peering at the firmware image.

Alan

  reply	other threads:[~2008-06-16 20:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16  9:49 David Woodhouse
2008-06-16 10:59 ` Alan Cox
2008-06-16 12:06   ` David Woodhouse
2008-06-16 20:02   ` Jeff Garzik
2008-06-16 19:56     ` Alan Cox [this message]
2008-06-16 20:05     ` Jeff Garzik
2008-06-16 19:58       ` Alan Cox
2008-06-16 20:21         ` Jeff Garzik
2008-06-16 20:21           ` Alan Cox
2008-06-16 21:39             ` Jeff Garzik
2008-06-16 21:34               ` Alan Cox
2008-06-16 22:01               ` David Woodhouse
2008-06-16 20:12 ` Jeff Garzik
2008-06-16 20:00   ` Alan Cox
2008-06-16 20:22     ` Jeff Garzik
2008-06-16 20:21       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080616205638.2e9930fe@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=jaswinder@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®