mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: linux-kernel@vger.kernel.org, mb@bu3sch.de,
	david@identd.dyndns.org, linux-wireless@vger.kernel.org,
	mingo@elte.hu, torvalds@linux-foundation.org
Subject: Re: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable
Date: Tue, 17 Jun 2008 16:08:39 -0700 (PDT)	[thread overview]
Message-ID: <20080617.160839.112511197.davem@davemloft.net> (raw)
In-Reply-To: <1213739834.3803.137.camel@johannes.berg>

From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 17 Jun 2008 23:57:14 +0200

> This warning has started to trigger with mac80211 because it can, under
> some circumstances, use spin_lock_bh() protected sections within
> irq-disabled sections. Is that a bug?

It is a bug.  The only legal nesting is base --> BH --> IRQ locking.

> Also, if you're going to treat IRQs being enabled as a bug, there's no
> point in disabling them right afterwards, is there?

It's treating IRQs being "disabled" as a bug.  It expects them to
be enabled, always.

> If you're going to reject this patch, I'll post one that adds the
> warning to local_bh_enable_ip() to allow detecting this for everybody
> and not just those poor people running UP/NO-PREEMPT :)

That might be useful :)

  reply	other threads:[~2008-06-17 23:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 21:57 Johannes Berg
2008-06-17 23:08 ` David Miller [this message]
2008-06-17 23:55 ` Linus Torvalds
2008-06-18  7:01   ` Peter Zijlstra
2008-06-18  7:29   ` Johannes Berg
2008-06-20 13:46     ` Ingo Molnar
2008-06-20 15:27       ` Ingo Molnar
2008-06-20 15:36         ` Michael Buesch
2008-06-20 15:55           ` Ingo Molnar
2008-06-20 16:01             ` Michael Buesch
2008-06-20 16:18               ` Michael Buesch
2008-06-23  8:41                 ` Ingo Molnar
2008-06-23  9:22                   ` Michael Buesch
2008-06-27  5:33                   ` Jeff Garzik
2008-06-27 10:53                     ` Ingo Molnar
2008-06-27 10:56                       ` Johannes Berg
2008-06-20 15:43         ` Johannes Berg
2008-06-20 15:46           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080617.160839.112511197.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=david@identd.dyndns.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®