mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mpatocka@redhat.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, agk@redhat.com
Subject: Re: stack overflow on Sparc64
Date: Fri, 20 Jun 2008 15:28:47 -0700 (PDT)	[thread overview]
Message-ID: <20080620.152847.169209890.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0806201819430.25997@engineering.redhat.com>

From: Mikulas Patocka <mpatocka@redhat.com>
Date: Fri, 20 Jun 2008 18:22:33 -0400 (EDT)

> On Fri, 20 Jun 2008, David Miller wrote:
> 
> > From: David Miller <davem@davemloft.net>
> > Date: Fri, 20 Jun 2008 14:44:24 -0700 (PDT)
> >
> >> I agree on both counts.  Although I'm curious what the average stack
> >> frame sizes look like on x86_64 and i386, and also how this area
> >> appears on powerpc.
> >
> > I also one to mention in passing that another thing we can do to
> > help deep call stack sizes is to make call chains more tail-call
> > friendly when possible.
> 
> ... and remove -fno-optimize-sibling-calls?:
> 
> Makefile:
> ifdef CONFIG_FRAME_POINTER
> KBUILD_CFLAGS   += -fno-omit-frame-pointer -fno-optimize-sibling-calls
> else
> KBUILD_CFLAGS   += -fomit-frame-pointer
> endif
> 
> --- maybe it could be better to remove it, instead of some inlining that I 
> made. Or do you see a situation when for debugging purpose, user would 
> want -fno-optimize-sibling-calls?

Yes for debugging and other things it has to stay.

  reply	other threads:[~2008-06-20 22:28 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  0:47 Mikulas Patocka
2008-06-18  4:01 ` David Miller
2008-06-19  3:24   ` Mikulas Patocka
2008-06-19  3:59     ` David Miller
2008-06-19  5:17       ` Mikulas Patocka
2008-06-19  6:37         ` David Miller
2008-06-19 13:01           ` Mikulas Patocka
2008-06-20 15:47   ` Mikulas Patocka
2008-06-20 17:26     ` David Miller
2008-06-20 20:34       ` Mikulas Patocka
2008-06-20 20:37         ` David Miller
2008-06-20 21:26           ` Mikulas Patocka
2008-06-20 21:41             ` David Miller
2008-06-21  4:51               ` David Miller
2008-06-21 19:42                 ` Mikulas Patocka
2008-06-22  7:03                   ` David Miller
2008-06-22 13:48                     ` Mikulas Patocka
2008-08-12  6:30                   ` David Miller
2008-08-12  8:22                     ` David Miller
2008-08-13  0:53                       ` Mikulas Patocka
2008-08-13  0:59                         ` David Miller
2008-08-13  1:11                     ` console handover badness [was: stack overflow on Sparc64] Mikulas Patocka
2008-08-13  1:22                       ` console handover badness David Miller
2008-08-13  1:40                       ` David Miller
2008-08-13  8:50                         ` David Miller
2008-08-13 12:46                         ` Mikulas Patocka
2008-08-14  3:25                           ` David Miller
2008-08-14 23:11                             ` Bootmem allocator broken [was: console handover badness] Mikulas Patocka
2008-08-14 23:25                               ` Bootmem allocator broken David Miller
2008-08-15 11:09                                 ` Alexander Beregalov
2008-08-15 21:13                                   ` David Miller
2008-08-14 23:40                               ` Johannes Weiner
2008-06-20 21:14       ` stack overflow on Sparc64 Mikulas Patocka
2008-06-20 21:20         ` David Miller
2008-06-20 21:25           ` Mikulas Patocka
2008-06-20 21:44             ` David Miller
2008-06-20 21:47               ` David Miller
2008-06-20 22:22                 ` Mikulas Patocka
2008-06-20 22:28                   ` David Miller [this message]
2008-06-20 22:36                     ` Mikulas Patocka
2008-06-20 22:47                       ` David Miller
2008-06-21  0:37                         ` Mikulas Patocka
2008-06-20 22:33               ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080620.152847.169209890.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=agk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®