* [PATCH] x86: remove unnecessary #ifdef CONFIG_X86_32...#else
@ 2008-06-25 7:03 Gustavo Fernando Padovan
2008-07-03 13:09 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Fernando Padovan @ 2008-06-25 7:03 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
Remove the #ifdef conditional because this comparison is already done in
user_mode_vm().
Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -55,11 +55,7 @@ static inline int notify_page_fault(struct pt_regs *regs)
int ret = 0;
/* kprobe_running() needs smp_processor_id() */
-#ifdef CONFIG_X86_32
if (!user_mode_vm(regs)) {
-#else
- if (!user_mode(regs)) {
-#endif
preempt_disable();
if (kprobe_running() && kprobe_fault_handler(regs, 14))
ret = 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: remove unnecessary #ifdef CONFIG_X86_32...#else
2008-06-25 7:03 [PATCH] x86: remove unnecessary #ifdef CONFIG_X86_32...#else Gustavo Fernando Padovan
@ 2008-07-03 13:09 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-03 13:09 UTC (permalink / raw)
To: Gustavo Fernando Padovan
Cc: linux-kernel, akpm, Vegard Nossum, the arch/x86 maintainers
* Gustavo Fernando Padovan <gustavo@las.ic.unicamp.br> wrote:
> Remove the #ifdef conditional because this comparison is already done
> in user_mode_vm().
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
applied to tip/x86/cleanups - thanks Gustavo.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-03 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-25 7:03 [PATCH] x86: remove unnecessary #ifdef CONFIG_X86_32...#else Gustavo Fernando Padovan
2008-07-03 13:09 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®