mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: Limit E820 map when a user-defined memory map is specified
@ 2008-06-25 19:39 Bernhard Walle
  2008-06-25 19:59 ` Yinghai Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Bernhard Walle @ 2008-06-25 19:39 UTC (permalink / raw)
  To: x86; +Cc: linux-kernel, yhlu.kernel, kexec, vgoyal, Bernhard Walle

This patch brings back limiting of the E820 map when a user-defined
E820 map is specified. While the behaviour of i386 (32 bit) was to limit
the E820 map (and /proc/iomem), the behaviour of x86-64 (64 bit) was not to
limit.

That patch limits the E820 map again for both x86 architectures.

Code was tested for compilation and booting on a 32 bit and 64 bit system.


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 arch/x86/kernel/e820.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index a1b0548..3771386 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -988,6 +988,9 @@ static int __init parse_memopt(char *p)
 
 	mem_size = memparse(p, &p);
 	end_user_pfn = mem_size>>PAGE_SHIFT;
+	e820_update_range(mem_size, ULLONG_MAX - mem_size,
+		E820_RAM, E820_RESERVED);
+
 	return 0;
 }
 early_param("mem", parse_memopt);
@@ -1032,6 +1035,8 @@ static int __init parse_memmap_opt(char *p)
 		e820_add_region(start_at, mem_size, E820_RESERVED);
 	} else {
 		end_user_pfn = (mem_size >> PAGE_SHIFT);
+		e820_update_range(mem_size, ULLONG_MAX - mem_size,
+			E820_RAM, E820_RESERVED);
 	}
 	return *p == '\0' ? 0 : -EINVAL;
 }
-- 
1.5.4.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: Limit E820 map when a user-defined memory map is specified
  2008-06-25 19:39 [PATCH] x86: Limit E820 map when a user-defined memory map is specified Bernhard Walle
@ 2008-06-25 19:59 ` Yinghai Lu
  2008-06-26 13:22   ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-06-25 19:59 UTC (permalink / raw)
  To: Bernhard Walle; +Cc: x86, linux-kernel, kexec, vgoyal

On Wed, Jun 25, 2008 at 12:39 PM, Bernhard Walle <bwalle@suse.de> wrote:
> This patch brings back limiting of the E820 map when a user-defined
> E820 map is specified. While the behaviour of i386 (32 bit) was to limit
> the E820 map (and /proc/iomem), the behaviour of x86-64 (64 bit) was not to
> limit.
>
> That patch limits the E820 map again for both x86 architectures.
>
> Code was tested for compilation and booting on a 32 bit and 64 bit system.
>
>
> Signed-off-by: Bernhard Walle <bwalle@suse.de>

Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>

> ---
>  arch/x86/kernel/e820.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> index a1b0548..3771386 100644
> --- a/arch/x86/kernel/e820.c
> +++ b/arch/x86/kernel/e820.c
> @@ -988,6 +988,9 @@ static int __init parse_memopt(char *p)
>
>        mem_size = memparse(p, &p);
>        end_user_pfn = mem_size>>PAGE_SHIFT;
> +       e820_update_range(mem_size, ULLONG_MAX - mem_size,
> +               E820_RAM, E820_RESERVED);
> +
>        return 0;
>  }
>  early_param("mem", parse_memopt);
> @@ -1032,6 +1035,8 @@ static int __init parse_memmap_opt(char *p)
>                e820_add_region(start_at, mem_size, E820_RESERVED);
>        } else {
>                end_user_pfn = (mem_size >> PAGE_SHIFT);
> +               e820_update_range(mem_size, ULLONG_MAX - mem_size,
> +                       E820_RAM, E820_RESERVED);
>        }
>        return *p == '\0' ? 0 : -EINVAL;
>  }
> --

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: Limit E820 map when a user-defined memory map is specified
  2008-06-25 19:59 ` Yinghai Lu
@ 2008-06-26 13:22   ` Ingo Molnar
  0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-06-26 13:22 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: Bernhard Walle, x86, linux-kernel, kexec, vgoyal


* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> On Wed, Jun 25, 2008 at 12:39 PM, Bernhard Walle <bwalle@suse.de> wrote:
> > This patch brings back limiting of the E820 map when a user-defined
> > E820 map is specified. While the behaviour of i386 (32 bit) was to limit
> > the E820 map (and /proc/iomem), the behaviour of x86-64 (64 bit) was not to
> > limit.
> >
> > That patch limits the E820 map again for both x86 architectures.
> >
> > Code was tested for compilation and booting on a 32 bit and 64 bit system.
> >
> >
> > Signed-off-by: Bernhard Walle <bwalle@suse.de>
> 
> Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>

applied to tip/x86/unify-setup - thanks.

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-26 13:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-25 19:39 [PATCH] x86: Limit E820 map when a user-defined memory map is specified Bernhard Walle
2008-06-25 19:59 ` Yinghai Lu
2008-06-26 13:22   ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®