mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Lee Schermerhorn <lee.schermerhorn@hp.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Balbir Singh <balbir@in.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splitlru: memcg swapbacked pages active
Date: Sun, 29 Jun 2008 17:19:31 +0900	[thread overview]
Message-ID: <20080629171251.37CA.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806290120270.21758@blonde.site>

> add_to_page_cache_lru puts PageSwapBacked pages on the active_anon lru,
> so shouldn't mem_cgroup_charge_common mirror that by setting FLAG_ACTIVE?
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

I don't think so.

in global lru, active vs inactive anon ratio is controlled by 
inactive_anon_is_low().
but memcg doesn't have any sililar things.

thus, this patch increase active anon. and too many active page cause
decrease reclaim throuput.

yes, We should implement SEQ replacement reclaim (like global reclaim)
for memcg.
I'm working on this.




  reply	other threads:[~2008-06-29  8:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-29  0:20 [PATCH] splitlru: shmem_getpage SetPageSwapBacked sooner Hugh Dickins
2008-06-29  0:22 ` [PATCH] splitlru: memcg swapbacked pages active Hugh Dickins
2008-06-29  8:19   ` KOSAKI Motohiro [this message]
2008-06-29 12:20     ` Hugh Dickins
2008-06-29 12:58       ` KOSAKI Motohiro
2008-06-29 13:51         ` Hugh Dickins
2008-06-30  2:44   ` KAMEZAWA Hiroyuki
2008-06-30 19:19     ` Hugh Dickins
2008-06-30  8:36   ` [RFC][PATCH] memcg: change shmem handler KAMEZAWA Hiroyuki
2008-06-30 19:52     ` Hugh Dickins
2008-07-01  0:56     ` kamezawa.hiroyu
2008-07-02  2:16       ` [RFC][PATCH] memcg: shmem swap cache KAMEZAWA Hiroyuki
2008-07-01  1:06     ` Re: Re: [RFC][PATCH] memcg: change shmem handler kamezawa.hiroyu
2008-07-03  7:15     ` Balbir Singh
2008-07-03  7:56       ` KAMEZAWA Hiroyuki
2008-06-29  0:24 ` [PATCH] splitlru: BDI_CAP_SWAP_BACKED Hugh Dickins
2008-06-29  8:48   ` KOSAKI Motohiro
2008-06-29 15:16     ` Rik van Riel
2008-06-30  2:53     ` KAMEZAWA Hiroyuki
2008-06-30 19:23       ` Hugh Dickins
2008-06-30 19:49         ` Rik van Riel
2008-06-30 20:55           ` Hugh Dickins
2008-06-30 21:17             ` Rik van Riel
2008-06-29  8:09 ` [PATCH] splitlru: shmem_getpage SetPageSwapBacked sooner KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080629171251.37CA.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®