From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [git pull] PCI fixes for 2.6.26
Date: Tue, 1 Jul 2008 10:04:47 -0700 [thread overview]
Message-ID: <200807011004.47487.jbarnes@virtuousgeek.org> (raw)
I'll stop making predictions about whether this is the last pull request for
2.6.26 or not, but it is an important one. It turns out that we've had a
trivial DoS on machines containing PCI devices with bad VPDs. We're
entertaining a few options for a scalable, long term fix, but in the
meantime, restricting access to the sysfs VPD file seems prudent. I've
included the patch in lieu of a diffstat since it's so small.
Thanks,
Jesse
Ben Hutchings (1):
PCI: Restrict VPD read permission to root
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 6f3c744..1f855f0 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -738,7 +738,7 @@ int __must_check pci_create_sysfs_dev_files (struct
pci_dev
pdev->vpd->attr = attr;
attr->size = pdev->vpd->ops->get_size(pdev);
attr->attr.name = "vpd";
- attr->attr.mode = S_IRUGO | S_IWUSR;
+ attr->attr.mode = S_IRUSR | S_IWUSR;
attr->read = pci_read_vpd;
attr->write = pci_write_vpd;
retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);
next reply other threads:[~2008-07-01 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:04 Jesse Barnes [this message]
2008-07-02 18:34 ` Jesse Barnes
2008-07-03 1:57 ` Linus Torvalds
2008-07-03 2:15 ` Jesse Barnes
2008-07-03 2:20 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807011004.47487.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome