[git pull] PCI fixes for 2.6.26

[git pull] PCI fixes for 2.6.26

[Jesse Barnes]

I'll stop making predictions about whether this is the last pull request for 
2.6.26 or not, but it is an important one.  It turns out that we've had a 
trivial DoS on machines containing PCI devices with bad VPDs.  We're 
entertaining a few options for a scalable, long term fix, but in the 
meantime, restricting access to the sysfs VPD file seems prudent.  I've 
included the patch in lieu of a diffstat since it's so small.

Thanks,
Jesse

Ben Hutchings (1):
      PCI: Restrict VPD read permission to root

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 6f3c744..1f855f0 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -738,7 +738,7 @@ int __must_check pci_create_sysfs_dev_files (struct 
pci_dev
                        pdev->vpd->attr = attr;
                        attr->size = pdev->vpd->ops->get_size(pdev);
                        attr->attr.name = "vpd";
-                       attr->attr.mode = S_IRUGO | S_IWUSR;
+                       attr->attr.mode = S_IRUSR | S_IWUSR;
                        attr->read = pci_read_vpd;
                        attr->write = pci_write_vpd;
                        retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);

Re: [git pull] PCI fixes for 2.6.26

[Jesse Barnes]

On Tuesday, July 01, 2008 10:04 am Jesse Barnes wrote:
> I'll stop making predictions about whether this is the last pull request
> for 2.6.26 or not, but it is an important one.  It turns out that we've had
> a trivial DoS on machines containing PCI devices with bad VPDs.  We're
> entertaining a few options for a scalable, long term fix, but in the
> meantime, restricting access to the sysfs VPD file seems prudent.  I've
> included the patch in lieu of a diffstat since it's so small.

Ok, doesn't look like you've pulled yet, so I queued up a couple more crash
fixes (shortlog & diffstat include previous stuff as well).

Alex Chiang (1):
      PCI: acpiphp: cleanup notify handler on all root bridges

Ben Hutchings (1):
      PCI: Restrict VPD read permission to root

Benjamin Li (1):
      PCI: Limit VPD read/write lengths for Broadcom 5706, 5708, 5709 rev.

 drivers/pci/access.c               |   14 +++---------
 drivers/pci/hotplug/acpiphp_glue.c |   17 ++++++++++++--
 drivers/pci/pci-sysfs.c            |    4 +--
 drivers/pci/pci.h                  |    2 -
 drivers/pci/quirks.c               |   42 +++++++++++++++++++++++++++++++++++++
 5 files changed, 63 insertions(+), 16 deletions(-)

Thanks,
Jesse

Re: [git pull] PCI fixes for 2.6.26

[Linus Torvalds]

On Wed, 2 Jul 2008, Jesse Barnes wrote:
> 
> Ok, doesn't look like you've pulled yet, so I queued up a couple more crash
> fixes (shortlog & diffstat include previous stuff as well).

Well, I won't be pulling, since you don't even tell me where to pull 
_from_, in either of your emails.

Yeah, yeah, I could easily guess, and it would work, but I'm not going to. 
Please just always include the repo URL and branch to pull from.

		Linus

Re: [git pull] PCI fixes for 2.6.26

[Jesse Barnes]

On Wednesday, July 02, 2008 6:57 pm Linus Torvalds wrote:
> On Wed, 2 Jul 2008, Jesse Barnes wrote:
> > Ok, doesn't look like you've pulled yet, so I queued up a couple more
> > crash fixes (shortlog & diffstat include previous stuff as well).
>
> Well, I won't be pulling, since you don't even tell me where to pull
> _from_, in either of your emails.
>
> Yeah, yeah, I could easily guess, and it would work, but I'm not going to.
> Please just always include the repo URL and branch to pull from.

Oh I fail.  I'll send a fresh pull request.

Jesse

[git pull] PCI fixes for 2.6.26

[Jesse Barnes]

Please pull some PCI fixes for 2.6.26:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6.git for-linus

This pull includes fixes for a few crashers.  They're not common (an ACPI
hotplug load/unload issue and an issue with the sysfs VPD file, so there's
no need to panic, but this stuff needs to get fixed asap nonetheless.

Thanks,
Jesse

Alex Chiang (1):
      PCI: acpiphp: cleanup notify handler on all root bridges

Ben Hutchings (1):
      PCI: Restrict VPD read permission to root

Benjamin Li (1):
      PCI: Limit VPD read/write lengths for Broadcom 5706, 5708, 5709 rev.

 drivers/pci/access.c               |   14 +++--------
 drivers/pci/hotplug/acpiphp_glue.c |   17 +++++++++++---
 drivers/pci/pci-sysfs.c            |    4 +--
 drivers/pci/pci.h                  |    2 -
 drivers/pci/quirks.c               |   42 +++++++++++++++++++++++++++++++++++
 5 files changed, 63 insertions(+), 16 deletions(-)