* [patch 1/1] MFD: SM501 fix gpio number calculation for upper bank
[not found] <20080702142918.143669690@fluff.org>
@ 2008-07-02 14:29 ` Ben Dooks
0 siblings, 0 replies; only message in thread
From: Ben Dooks @ 2008-07-02 14:29 UTC (permalink / raw)
To: akpm, linux-kernel; +Cc: Ben Dooks
[-- Attachment #1: simtec/simtec-drivers-mfd-sm501-gpionrfix.patch --]
[-- Type: text/plain, Size: 865 bytes --]
The sm501_gpio_pin2nr() routine returns the wrong values
for gpios in the upper bank.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc8-quilt3/drivers/mfd/sm501.c
===================================================================
--- linux-2.6.26-rc8-quilt3.orig/drivers/mfd/sm501.c 2008-07-02 14:17:49.000000000 +0100
+++ linux-2.6.26-rc8-quilt3/drivers/mfd/sm501.c 2008-07-02 14:44:06.000000000 +0100
@@ -1108,7 +1108,9 @@ static void sm501_gpio_remove(struct sm5
static inline int sm501_gpio_pin2nr(struct sm501_devdata *sm, unsigned int pin)
{
struct sm501_gpio *gpio = &sm->gpio;
- return pin + (pin < 32) ? gpio->low.gpio.base : gpio->high.gpio.base;
+ int base = (pin < 32) ? gpio->low.gpio.base : gpio->high.gpio.base;
+
+ return (pin % 32) + base;
}
static inline int sm501_gpio_isregistered(struct sm501_devdata *sm)
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-02 14:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20080702142918.143669690@fluff.org>
2008-07-02 14:29 ` [patch 1/1] MFD: SM501 fix gpio number calculation for upper bank Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®