mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Dave Airlie <airlied@gmail.com>,
	Keith Packard <keithp@keithp.com>, Dave Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: kmap_atomic_pfn for PCI BAR access?
Date: Mon, 7 Jul 2008 16:53:54 +1000	[thread overview]
Message-ID: <200807071653.55094.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <486308C9.5070709@goop.org>

On Thursday 26 June 2008 13:11, Jeremy Fitzhardinge wrote:
> Dave Airlie wrote:

> > doing tlb flush for iounmap is slow as all hell if you do it a lot,
> > and we can't afford to mmap the whole aperture it can 1GB.
>
> Maybe Nick's vmap reimplementation would help here.  It effectively
> allows you to map stuff into the vmalloc space, and do lazy tlb flushes
> to mitigate the cost of map/unmap.  He posted the patches week or so ago.

Yeah, it can _really_ help. I'd posted some performance numbers with
the patch which might prompt you to take another look at ioremap.

One thing I still haven't implemented in that patch are CPU-local
mappings (which only require a local flush to flush)... I found that
after the improvements I did implement, they didn't help much for
my workloads, so I suspect you might find the same thing... But anyway
if you really need the per-CPU mappings, it should be possible to
implement rather generically in vmap layer.

I would be very interested to know what sort of results you see with it
(compared to kmap_atomic and compared to vanilla ioremap)

Thanks,
Nick

  reply	other threads:[~2008-07-07  6:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-23 17:34 Keith Packard
2008-06-26  1:18 ` Jeremy Fitzhardinge
2008-06-26  1:23   ` Dave Airlie
2008-06-26  3:11     ` Jeremy Fitzhardinge
2008-07-07  6:53       ` Nick Piggin [this message]
2008-07-07  7:05         ` Arjan van de Ven
2008-07-07 11:19           ` Nick Piggin
2008-06-26  4:36     ` Arjan van de Ven
2008-06-26  5:02       ` Dave Airlie
2008-06-26  5:33         ` Keith Packard
2008-06-26  5:36       ` Keith Packard
2008-06-26  5:59         ` Jeremy Fitzhardinge
2008-06-26  6:02           ` Dave Airlie
2008-06-26 10:36             ` Arjan van de Ven
2008-06-26 13:02               ` Arjan van de Ven
2008-06-26 10:34         ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807071653.55094.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=jeremy@goop.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®