mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: david@lang.hm
Cc: David Miller <davem@davemloft.net>,
	mchan@broadcom.com, dwmw2@infradead.org, bastian@waldi.eu.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2 - use request_firmware()
Date: Tue, 8 Jul 2008 07:49:47 +0100	[thread overview]
Message-ID: <20080708074947.2734d71f@the-village.bc.nu> (raw)
In-Reply-To: <alpine.DEB.1.10.0807072028590.12950@asgard.lang.hm>

> so make the firmware part of the module if the driver is compiled as a 
> module. this way if the driver (and firmware) end up not being used they 
> don't take up any space. this seems a lot simpler (as well as more 
> reliable) then adding a mandatory dependancy on a different userspace 
> tool.

For the majority of drivers that would be a serious regression as they
load the firmware when needed, which is not when loaded. In some cases
there are many sets of firmware and only one is needed according to the
device, and only needed once per device detect.

It might well make sense for tg3 although even there it seems most tg3
work fine without loading new firmware, and examples like aic7xxx where
the firmware and code must match.

Alan

      reply	other threads:[~2008-07-08  7:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080704225415.GA557@wavehammer.waldi.eu.org>
2008-07-05  9:44 ` David Woodhouse
2008-07-07  4:21   ` Michael Chan
2008-07-07  7:53     ` Bastian Blank
2008-07-07  9:03     ` David Woodhouse
2008-07-07 18:56       ` Michael Chan
2008-07-07 21:38         ` David Miller
2008-07-07 21:19           ` Alan Cox
2008-07-07 22:05             ` David Miller
2008-07-08  6:39               ` Alan Cox
2008-07-08  8:58                 ` David Miller
2008-07-09 20:25                   ` request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware()) Pavel Machek
2008-07-09 21:13                     ` Rafael J. Wysocki
2008-07-09 21:20                       ` Theodore Tso
2008-07-09 21:58                         ` Rafael J. Wysocki
2008-07-09 22:23                           ` Theodore Tso
2008-07-09 22:33                             ` Rafael J. Wysocki
2008-07-07 22:08             ` [PATCH] bnx2 - use request_firmware() Jeff Garzik
2008-07-07 23:01               ` David Miller
2008-07-08  6:41               ` Alan Cox
2008-07-08  9:00                 ` David Miller
2008-07-08  3:30             ` david
2008-07-08  6:49               ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708074947.2734d71f@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bastian@waldi.eu.org \
    --cc=davem@davemloft.net \
    --cc=david@lang.hm \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®