Crypto Fixes for 2.6.26

Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

This push fixes three bugs in the recently added async crypto
path as well as a minor kzalloc error-path bug.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (2):
      [CRYPTO] api: Fix scatterwalk_sg_chain
      [CRYPTO] eseqiv: Fix off-by-one encryption

Julia Lawall (1):
      [CRYPTO] cryptd: Correct kzalloc error test

Patrick McHardy (1):
      [CRYPTO] authenc: Fix async crypto crash in crypto_authenc_genicv()

 crypto/authenc.c             |    5 +++--
 crypto/cryptd.c              |    4 +++-
 crypto/eseqiv.c              |    3 ++-
 include/crypto/scatterwalk.h |    4 ++++
 4 files changed, 12 insertions(+), 4 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

This push fixes a bug in HMAC that has been exposed by recent
changes in tcrypt.  However, it may well affect other crypto
users that put the key in places where virt_to_page doesn't work.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      [CRYPTO] hmac: Avoid calling virt_to_page on key

 crypto/hmac.c |   25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

This push fixes a crash in CTS when SG debugging is enabled as
it doesn't set the debugging markers.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Alexey Dobriyan (1):
      [CRYPTO] cts: Init SG tables

 crypto/cts.c |    6 ++++++
 1 file changed, 6 insertions(+)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

This push fixes a memory leak in the crypto testing module.  Since
this module is designed to be used repeatedly, the leak could add
up quickly.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Darren Jenkins (1):
      crypto: tcrypt - Fix memory leak in test_cipher

 crypto/tcrypt.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

Just found a regression introduced back in 2.6.25.  This causes
packet leaks when IPsec is in use.  When that leak grows it can
eventually lead to hung connections (as their send buffers are
used up) or worse.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: chainiv - Invoke completion function

 crypto/chainiv.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Herbert Xu]

Hi Linus:

This push reverts the CTR-based PRNG as it clearly isn't able
to pass Ingo's random config hurdle.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      Revert crypto: prng - Deterministic CPRNG

 crypto/Kconfig  |    9 -
 crypto/Makefile |    2 
 crypto/prng.c   |  410 --------------------------------------------------------
 crypto/prng.h   |   27 ---
 4 files changed, 1 insertion(+), 447 deletions(-)


Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.26

[Oliver Pinter]

[CC stable]

On 7/10/08, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Hi Linus:
>
> Just found a regression introduced back in 2.6.25.  This causes
> packet leaks when IPsec is in use.  When that leak grows it can
> eventually lead to hung connections (as their send buffers are
> used up) or worse.
>
> Please pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git
>
> or
>
> master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git
>
>
> Herbert Xu (1):
>       crypto: chainiv - Invoke completion function
>
>  crypto/chainiv.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> Thanks,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Thanks,
Oliver

Re: [stable] Crypto Fixes for 2.6.26

[Greg KH]

On Tue, Jul 15, 2008 at 07:07:47PM +0200, Oliver Pinter wrote:
> [CC stable]
> 
> On 7/10/08, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > Hi Linus:
> >
> > Just found a regression introduced back in 2.6.25.  This causes
> > packet leaks when IPsec is in use.  When that leak grows it can
> > eventually lead to hung connections (as their send buffers are
> > used up) or worse.
> >
> > Please pull from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

Herbert, can you let me know what the git commit id is for this fix?

And do you want it added to the .25 and .26 -stable releases?

Oliver, thanks for the pointer.

thanks,

greg k-h

Re: [stable] Crypto Fixes for 2.6.26

[Herbert Xu]

On Tue, Jul 15, 2008 at 10:17:36AM -0700, Greg KH wrote:
>
> Herbert, can you let me know what the git commit id is for this fix?
> 
> And do you want it added to the .25 and .26 -stable releases?
> 
> Oliver, thanks for the pointer.

Sorry, that was meant to say 2.6.27 :) So you don't need it
for stable.

cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [stable] Crypto Fixes for 2.6.26

[Herbert Xu]

On Wed, Jul 16, 2008 at 10:09:38AM +0800, Herbert Xu wrote:
> On Tue, Jul 15, 2008 at 10:17:36AM -0700, Greg KH wrote:
> >
> > Herbert, can you let me know what the git commit id is for this fix?
> > 
> > And do you want it added to the .25 and .26 -stable releases?
> > 
> > Oliver, thanks for the pointer.
> 
> Sorry, that was meant to say 2.6.27 :) So you don't need it
> for stable.

Wait, I thought you were talking about a different message.

The chainiv patch is certainly needed for 2.6.25 (not for 26
since it made the cut).  But I've already sent it to stable@.
If you don't have it let me know and I'll resend it.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 2.6.27

[Herbert Xu]

Hi Linus:

This push fixes a number of bugs in the recently added talitos
driver.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Kim Phillips (4):
      crypto: talitos - Preempt overflow interrupts
      crypto: talitos - Fix GFP flag usage
      crypto: talitos - Stop leaking memory in error path
      crypto: talitos - sparse fix

Lee Nipper (2):
      crypto: talitos - Remove calls to of_node_put
      crypto: talitos - Correct dst != src case handling

 drivers/crypto/talitos.c |   49 ++++++++++++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 15 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.27

[Herbert Xu]

Hi Linus:

This push contains a bunch of fixes for new code/regressions
introduced since 2.6.26 plus a fix for an old padlock bug that
has risen to the surface due to recent FPU changes.

Previously the bug was mostly harmless though it had the potential
to leak FPU state, but since 2.6.26 it has become lethal resulting
in crashes if the padlock is used during process creation.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (3):
      crypto: tcrypt - Fix AEAD chunk testing
      crypto: hash - Fix digest size check for digest type
      crypto: hash - Add missing top-level functions

Lee Nipper (1):
      crypto: talitos - Add handling for SEC 3.x treatment of link table

Suresh Siddha (1):
      crypto: padlock - fix VIA PadLock instruction usage with irq_ts_save/restore()

 crypto/digest.c                  |    2 -
 crypto/tcrypt.c                  |   28 +++++++++++++-------
 drivers/char/hw_random/via-rng.c |    8 +++++
 drivers/crypto/padlock-aes.c     |   28 +++++++++++++++++++-
 drivers/crypto/padlock-sha.c     |    9 ++++++
 drivers/crypto/talitos.c         |   54 ++++++++++++++++++++++++++++-----------
 include/asm-x86/i387.h           |   32 +++++++++++++++++++++++
 include/crypto/hash.h            |   18 +++++++++++++
 8 files changed, 153 insertions(+), 26 deletions(-)
 
Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.27

[Herbert Xu]

Hi Linus:

This push fixes a serious bug that was introduced in 2.6.25.  It
causes IPsec users that employ MAC algorithms with a length longer
than 16 bytes to crash.  The standard SHA1 algorithm is exactly 16
bytes long, so this only applies to those using longer algorithms
such as SHA256.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: authenc - Avoid using clobbered request pointer

 crypto/authenc.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.27

[Herbert Xu]

Hi Linus:

This push reverts a patch that caused a regression after 2.6.26.
It broke the Camellia algorithm which may be used by IPsec or for
encrypted disks.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      Revert "crypto: camellia - Use kernel-provided bitops, unaligned access helpers"

 crypto/camellia.c |   84 ++++++++++++++++++++++++++++++------------------------
 1 file changed, 48 insertions(+), 36 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.27

[Herbert Xu]

Hi Linus:

This push fixes a security problem in the talitos driver which
was added after 2.6.26.  When triggered talitos may cause two
IPsec packets to be generated with the same IV which weakens
the protection offered by encryption.  This only affects talitos
users obviously.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Kim Phillips (1):
      crypto: talitos - Avoid consecutive packets going out with same IV

 drivers/crypto/talitos.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes a crash in authenc that may occur if null encryption
is used (a rare configuration).

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: authenc - Fix zero-length IV crash

 crypto/authenc.c |   24 +++++++++++++++---------
 1 files changed, 15 insertions(+), 9 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes a number of minor bugs:

* A crash in authenc that may occur if null encryption is used
  (a rare configuration).
* Error handling in blkcipher_walk_done (though this error should
  never occur unless underlying algorithm is buggy).
* Crash in CCM with no association data (only occurs for certification
  testing).

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (2):
      crypto: authenc - Fix zero-length IV crash
      crypto: blkcipher - Fix WARN_ON handling in walk_done

Jarod Wilson (1):
      crypto: ccm - Fix handling of null assoc data

 crypto/authenc.c   |   24 +++++++++++++++---------
 crypto/blkcipher.c |    2 +-
 crypto/ccm.c       |    2 ++
 3 files changed, 18 insertions(+), 10 deletions(-)
 
Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes a number of bugs/regerssions:

* shash modules weren't ref counted properly.
* AEAD initialisation may fail which broke IPsec.
* Not all memory were zeroed when a crypto tfm is freed.
* We were doing flush_dcache_page on slab pages.
 
Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Adrian-Ken Rueegsegger (1):
      crypto: shash - Fix module refcount

Herbert Xu (4):
      crypto: api - Fix algorithm test race that broke aead initialisation
      crypto: api - Fix zeroing on free
      crypto: shash - Fix tfm destruction
      crypto: scatterwalk - Avoid flush_dcache_page on slab pages

 crypto/algapi.c        |    6 +++++-
 crypto/api.c           |   20 ++++++++++----------
 crypto/scatterwalk.c   |    3 ++-
 crypto/shash.c         |    7 ++++++-
 include/crypto/hash.h  |    2 +-
 include/linux/crypto.h |    7 ++++++-
 6 files changed, 30 insertions(+), 15 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes LRW (used for disk encryption) on big endian.
It turns out that it just never worked over there.  Based on
the fact that nobody screamed about it after the addition of
mandatory testing, it seems that it just isn't used so we don't
have to worry about existing big-endian LRW deployments.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: lrw - Fix big endian support

 crypto/lrw.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
 
Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes a bug in /proc/crypto where it may display a
bogus digest size for ahash algorithms.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Lee Nipper (1):
      crypto: ahash - Fix digest size in /proc/crypto

 crypto/ahash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes a 2.6.27 regression where the new test mechanism
can cause the optimised AES implementation on s390 to hang on
initial module load.  The same thing can affect the VIA PadLock,
although modprobe alias ordering may have prevented it from
occurring.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: api - Fix module load deadlock with fallback algorithms

 arch/s390/crypto/aes_s390.c  |    2 +-
 crypto/api.c                 |   15 +++++++++++++--
 drivers/crypto/padlock-aes.c |    2 +-
 drivers/crypto/padlock-sha.c |    4 ++--
 4 files changed, 17 insertions(+), 6 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 2.6.29

[Herbert Xu]

Hi Linus:

This push fixes two bugs:

* A 2.6.27 regression where the new test mechanism can cause the
optimised AES implementation on s390 to hang on initial module
load.  The same thing can affect the VIA PadLock, although modprobe
alias ordering may have prevented it from occurring.

* A build error in the ixp4xx driver.

Please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git

or

master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git


Herbert Xu (1):
      crypto: api - Fix module load deadlock with fallback algorithms

Krzysztof Hałasa (1):
      crypto: ixp4xx - Fix qmgr_request_queue build failure

 arch/s390/crypto/aes_s390.c    |    2 +-
 crypto/api.c                   |   15 +++++++++++++--
 drivers/crypto/ixp4xx_crypto.c |    6 ++++--
 drivers/crypto/padlock-aes.c   |    2 +-
 drivers/crypto/padlock-sha.c   |    4 ++--
 5 files changed, 21 insertions(+), 8 deletions(-)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt