* [PATCH] net/ipv4/tcp.c: Fix use of PULLHUP instead of POLLHUP in comments.
@ 2008-07-16 15:30 Will Newton
2008-07-17 3:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2008-07-16 15:30 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, Will Newton
From: Will Newton <will.newton@gmail.com>
Change PULLHUP to POLLHUP in tcp_poll comments and clean up another
comment for grammar and coding style.
Signed-off-by: Will Newton <will.newton@gmail.com>
---
net/ipv4/tcp.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 1d723de..b343ce3 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -346,8 +346,8 @@ unsigned int tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
return inet_csk_listen_poll(sk);
/* Socket is not locked. We are protected from async events
- by poll logic and correct handling of state changes
- made by another threads is impossible in any case.
+ * by poll logic and correct handling of state changes
+ * made by other threads is impossible in any case.
*/
mask = 0;
@@ -373,10 +373,10 @@ unsigned int tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
* in state CLOSE_WAIT. One solution is evident --- to set POLLHUP
* if and only if shutdown has been made in both directions.
* Actually, it is interesting to look how Solaris and DUX
- * solve this dilemma. I would prefer, if PULLHUP were maskable,
+ * solve this dilemma. I would prefer, if POLLHUP were maskable,
* then we could set it on SND_SHUTDOWN. BTW examples given
* in Stevens' books assume exactly this behaviour, it explains
- * why PULLHUP is incompatible with POLLOUT. --ANK
+ * why POLLHUP is incompatible with POLLOUT. --ANK
*
* NOTE. Check for TCP_CLOSE is added. The goal is to prevent
* blocking on fresh not-connected or disconnected socket. --ANK
--
1.5.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ipv4/tcp.c: Fix use of PULLHUP instead of POLLHUP in comments.
2008-07-16 15:30 [PATCH] net/ipv4/tcp.c: Fix use of PULLHUP instead of POLLHUP in comments Will Newton
@ 2008-07-17 3:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-17 3:13 UTC (permalink / raw)
To: will.newton; +Cc: linux-kernel, netdev, will.newton
From: Will Newton <will.newton@imgtec.com>
Date: Wed, 16 Jul 2008 16:30:35 +0100
> Change PULLHUP to POLLHUP in tcp_poll comments and clean up another
> comment for grammar and coding style.
>
> Signed-off-by: Will Newton <will.newton@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-17 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-16 15:30 [PATCH] net/ipv4/tcp.c: Fix use of PULLHUP instead of POLLHUP in comments Will Newton
2008-07-17 3:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®