* [PATCH] x86: I/O APIC: Include <asm/i8259.h> required by some code
@ 2008-07-14 16:18 Maciej W. Rozycki
2008-07-18 12:21 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2008-07-14 16:18 UTC (permalink / raw)
To: Ingo Molnar; +Cc: x86, linux-kernel
Include <asm/i8259.h> for i8259A_lock used in print_PIC() -- #if-0-ed out
by default. The 32-bit version gets it right already.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
The plan is to enable this code with "apic=debug" eventually. This will
aid with debugging strange problems without the need to ask people to
apply patches.
Maciej
patch-next-2.6.26-rc9-20080711-apic-pic-i8259-h-0
diff -up --recursive --new-file linux-next-2.6.26-rc9-20080711.macro/arch/x86/kernel/io_apic_64.c linux-next-2.6.26-rc9-20080711/arch/x86/kernel/io_apic_64.c
--- linux-next-2.6.26-rc9-20080711.macro/arch/x86/kernel/io_apic_64.c 2008-07-14 15:44:12.000000000 +0000
+++ linux-next-2.6.26-rc9-20080711/arch/x86/kernel/io_apic_64.c 2008-07-14 15:47:19.000000000 +0000
@@ -45,6 +45,7 @@
#include <asm/proto.h>
#include <asm/acpi.h>
#include <asm/dma.h>
+#include <asm/i8259.h>
#include <asm/nmi.h>
#include <asm/msidef.h>
#include <asm/hypertransport.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: I/O APIC: Include <asm/i8259.h> required by some code
2008-07-14 16:18 [PATCH] x86: I/O APIC: Include <asm/i8259.h> required by some code Maciej W. Rozycki
@ 2008-07-18 12:21 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-18 12:21 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: x86, linux-kernel
* Maciej W. Rozycki <macro@linux-mips.org> wrote:
> Include <asm/i8259.h> for i8259A_lock used in print_PIC() -- #if-0-ed out
> by default. The 32-bit version gets it right already.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> The plan is to enable this code with "apic=debug" eventually. This will
> aid with debugging strange problems without the need to ask people to
> apply patches.
applied to tip/x86/apic, thanks Maciej.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-14 16:18 [PATCH] x86: I/O APIC: Include <asm/i8259.h> required by some code Maciej W. Rozycki
2008-07-18 12:21 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®