[PATCH] Fix typos from signal_32/64.h merge

[PATCH] Fix typos from signal_32/64.h merge

[Herton Ronaldo Krzesinski]

Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86:
merge signal_32/64.h")

Thanks to Dick Streefland who provided an useful testcase on
http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that
helped a lot as a deterministic way to bisect an issue that leaded to
this fix.

Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
---
 include/asm-x86/signal.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/signal.h b/include/asm-x86/signal.h
index f15186d..6dac493 100644
--- a/include/asm-x86/signal.h
+++ b/include/asm-x86/signal.h
@@ -181,12 +181,12 @@ typedef struct sigaltstack {
 #ifdef __KERNEL__
 #include <asm/sigcontext.h>
 
-#ifdef __386__
+#ifdef __i386__
 
 #define __HAVE_ARCH_SIG_BITOPS
 
 #define sigaddset(set,sig)		    \
-	(__builtin_constantp(sig)	    \
+	(__builtin_constant_p(sig)	    \
 	 ? __const_sigaddset((set), (sig))  \
 	 : __gen_sigaddset((set), (sig)))
 
-- 
1.5.6

Re: [PATCH] Fix typos from signal_32/64.h merge

[Luiz Fernando N. Capitulino]

Em Mon, 14 Jul 2008 17:40:23 -0300
Herton Ronaldo Krzesinski <herton@mandriva.com.br> escreveu:

| Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86:
| merge signal_32/64.h")
| 
| Thanks to Dick Streefland who provided an useful testcase on
| http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that
| helped a lot as a deterministic way to bisect an issue that leaded to
| this fix.

 Just a small note. On 2.6.24.x this causes gdb to get unexpected
SIGTRAPs, which (for some reason) is easy to reproduce when debugging
C++/QT programs.

 And I have no idea on what kind of bug this is causing in latest
2.6.26 kernel.

-- 
Luiz Fernando N. Capitulino

Re: [PATCH] Fix typos from signal_32/64.h merge

[Ingo Molnar]

* Herton Ronaldo Krzesinski <herton@mandriva.com.br> wrote:

> Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86: 
> merge signal_32/64.h")
> 
> Thanks to Dick Streefland who provided an useful testcase on 
> http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that 
> helped a lot as a deterministic way to bisect an issue that leaded to 
> this fix.

applied to tip/x86/urgent, thanks Herton!

	Ingo