mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] sysctl: fix build when SYSCTL=y, SYSCTL_SYSCALL=n
@ 2008-07-19  0:26 Randy Dunlap
  0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2008-07-19  0:26 UTC (permalink / raw)
  To: lkml; +Cc: akpm

From: Randy Dunlap <randy.dunlap@oracle.com>

The stub needs to be provided when CONFIG_SYSCTL=n, not when
CONFIG_SYSCTL_SYSCALL=n.

linux-next-20080718/kernel/sysctl.c:2970: error: redefinition of 'setup_sysctl_set'
linux-next-20080718/kernel/sysctl.c:1963: error: previous definition of 'setup_sysctl_set' was here

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 kernel/sysctl.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- linux-next-20080718.orig/kernel/sysctl.c
+++ linux-next-20080718/kernel/sysctl.c
@@ -1982,6 +1982,12 @@ void unregister_sysctl_table(struct ctl_
 {
 }
 
+void setup_sysctl_set(struct ctl_table_set *p,
+	struct ctl_table_set *parent,
+	int (*is_seen)(struct ctl_table_set *))
+{
+}
+
 #endif /* CONFIG_SYSCTL */
 
 /*
@@ -2964,12 +2970,6 @@ int sysctl_ms_jiffies(struct ctl_table *
 	return -ENOSYS;
 }
 
-void setup_sysctl_set(struct ctl_table_set *p,
-	struct ctl_table_set *parent,
-	int (*is_seen)(struct ctl_table_set *))
-{
-}
-
 #endif /* CONFIG_SYSCTL_SYSCALL */
 
 static int deprecated_sysctl_warning(struct __sysctl_args *args)


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-07-19  0:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-19  0:26 [PATCH -next] sysctl: fix build when SYSCTL=y, SYSCTL_SYSCALL=n Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®