mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kexec@lists.infradead.org
Subject: Re: [Patch] kexec: remove redundant if-else
Date: Sat, 19 Jul 2008 11:16:35 +0100	[thread overview]
Message-ID: <20080719101635.GB3558@hack.netcabo.pt> (raw)
In-Reply-To: <m1sku7j6qp.fsf@frodo.ebiederm.org>

On Fri, Jul 18, 2008 at 01:07:58PM -0700, Eric W. Biederman wrote:
>WANG Cong <xiyou.wangcong@gmail.com> writes:
>
>> These if-else's can be removed.
>
>Why?  That appears to be pointless code style thrashing.


I don't think that is coding style fix. Because when we arrive the
'out' branch, 'result' is always properly set, thus checking it again
is useless for me. :-)

Thanks.

-- 
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.

      reply	other threads:[~2008-07-19 10:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 15:04 WANG Cong
2008-07-18 20:07 ` Eric W. Biederman
2008-07-19 10:16   ` WANG Cong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080719101635.GB3558@hack.netcabo.pt \
    --to=xiyou.wangcong@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®