From: ebiederm@xmission.com (Eric W. Biederman)
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kexec@lists.infradead.org
Subject: Re: [Patch] kexec: remove redundant if-else
Date: Fri, 18 Jul 2008 13:07:58 -0700 [thread overview]
Message-ID: <m1sku7j6qp.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <20080718150410.GB26261@hack.voiplan.pt> (WANG Cong's message of "Fri, 18 Jul 2008 16:04:10 +0100")
WANG Cong <xiyou.wangcong@gmail.com> writes:
> These if-else's can be removed.
Why? That appears to be pointless code style thrashing.
Converting code with a single return into code with multiple returns.
Which arguably makes it harder to prove properties about.
Further if you want to use the style you suggest a label name like err
is better than the name out.
But in this case where we have multiple results I don't like the proposed
change in style at all. Especially with no rational.
Eric
next prev parent reply other threads:[~2008-07-18 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 15:04 WANG Cong
2008-07-18 20:07 ` Eric W. Biederman [this message]
2008-07-19 10:16 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1sku7j6qp.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®