From: Adrian Bunk <bunk@kernel.org>
To: Andrea Righi <righi.andrea@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: PAGE_ALIGN() compile breakage
Date: Fri, 25 Jul 2008 11:39:43 +0300 [thread overview]
Message-ID: <20080725083943.GC19310@cs181140183.pp.htv.fi> (raw)
Commit 27ac792ca0b0a1e7e65f20342260650516c95864
(PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures)
causes on some architectures (e.g. avr32 and mips) compile errors
like the following in some configurations starting with:
<-- snip -->
...
CC init/main.o
In file included from
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/utsname.h:35,
from /home/bunk/linux/kernel-2.6/git/linux-2.6/init/main.c:20:
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In function 'arch_pick_mmap_layout':
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:2149: error: implicit declaration of function 'PAGE_ALIGN'
make[2]: *** [init/main.o] Error 1
<-- snip -->
and more nasty problems follow later.
My suggestion is to:
- revert commit 27ac792ca0b0a1e7e65f20342260650516c95864 and then
- fix all PAGE_ALIGN() instances without moving them.
Unifying code is a good thing, but in this case it is not worth the
trouble it causes by poking into the heart of our headers mess.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2008-07-25 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 8:39 Adrian Bunk [this message]
2008-07-25 8:55 ` Andrew Morton
2008-07-25 9:14 ` Adrian Bunk
2008-07-25 9:25 ` Andrew Morton
2008-07-25 18:34 ` Andrea Righi
2008-07-25 9:27 ` Adrian Bunk
2008-07-25 9:34 ` Andrew Morton
2008-07-25 12:24 ` __weak vs ifdef Matthew Wilcox
2008-07-25 12:41 ` Andrew Morton
2008-07-26 19:38 ` Linus Torvalds
2010-02-18 2:07 ` Grant Likely
2010-02-18 2:22 ` Linus Torvalds
2008-07-26 21:22 ` [-mm patch] mm/util.c must #include <linux/sched.h> Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725083943.GC19310@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=righi.andrea@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®