* 2.6.26-<mumble> question regarding kernel/lockdep.c
@ 2008-07-23 0:20 Valdis.Kletnieks
2008-07-28 15:01 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Valdis.Kletnieks @ 2008-07-23 0:20 UTC (permalink / raw)
To: mingo, peterz; +Cc: Andrew Morton, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
I was chasing after some weird behavior with lockdep, and I found that
almost none of the printk() calls in kernel/lockdep.c have a KERN_FOO
level specified.
It looks like it could use patching, but before I code something, I
need to know if the patch should be doing:
a) Adding the missing KERN_FOO levels..
or
b) Adding a comment explaining the subtle reason they're not there...
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.26-<mumble> question regarding kernel/lockdep.c
2008-07-23 0:20 2.6.26-<mumble> question regarding kernel/lockdep.c Valdis.Kletnieks
@ 2008-07-28 15:01 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-07-28 15:01 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: mingo, peterz, Andrew Morton, linux-kernel
* Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:
> I was chasing after some weird behavior with lockdep, and I found that
> almost none of the printk() calls in kernel/lockdep.c have a KERN_FOO
> level specified.
>
> It looks like it could use patching, but before I code something, I
> need to know if the patch should be doing:
>
> a) Adding the missing KERN_FOO levels..
> or
> b) Adding a comment explaining the subtle reason they're not there...
i guess most could/should be converted to pr_info() - and a couple of
them need to be KERN_CONT.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-28 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-23 0:20 2.6.26-<mumble> question regarding kernel/lockdep.c Valdis.Kletnieks
2008-07-28 15:01 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome