From: Miklos Szeredi <miklos@szeredi.hu>
To: viro@ZenIV.linux.org.uk
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [patch 2/4] vfs: filp is never NULL in do_generic_file_read()
Date: Wed, 30 Jul 2008 15:08:47 +0200 [thread overview]
Message-ID: <20080730130914.500576799@szeredi.hu> (raw)
In-Reply-To: <20080730130845.905327725@szeredi.hu>
[-- Attachment #1: do_generic_file_read_cleanup.patch --]
[-- Type: text/plain, Size: 679 bytes --]
From: Miklos Szeredi <mszeredi@suse.cz>
...so remove bogus "if (filp)".
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
mm/filemap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c 2008-07-30 13:52:36.000000000 +0200
+++ linux-2.6/mm/filemap.c 2008-07-30 13:52:39.000000000 +0200
@@ -1186,8 +1186,7 @@ out:
ra->prev_pos |= prev_offset;
*ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
- if (filp)
- file_accessed(filp);
+ file_accessed(filp);
}
int file_read_actor(read_descriptor_t *desc, struct page *page,
--
next prev parent reply other threads:[~2008-07-30 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 13:08 [patch 0/4] vfs: trivial cleanups Miklos Szeredi
2008-07-30 13:08 ` [patch 1/4] splice: fix comment Miklos Szeredi
2008-07-30 13:08 ` Miklos Szeredi [this message]
2008-07-31 7:19 ` [patch 2/4] vfs: filp is never NULL in do_generic_file_read() KOSAKI Motohiro
2008-07-31 7:30 ` Li Zefan
2008-07-30 13:08 ` [patch 3/4] vfs: remove unused nameidata argument of may_create() Miklos Szeredi
2008-07-30 13:08 ` [patch 4/4] vfs: create file_truncate() helper Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730130914.500576799@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®