From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: kosaki.motohiro@jp.fujitsu.com, viro@ZenIV.linux.org.uk,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/4] vfs: filp is never NULL in do_generic_file_read()
Date: Thu, 31 Jul 2008 16:19:08 +0900 [thread overview]
Message-ID: <20080731161554.3C84.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20080730130914.500576799@szeredi.hu>
> *ppos = ((loff_t)index << PAGE_CACHE_SHIFT) + offset;
> - if (filp)
> - file_accessed(filp);
> + file_accessed(filp);
> }
>
> int file_read_actor(read_descriptor_t *desc, struct page *page,
if filp is never NULL, BUG_ON is better?
next prev parent reply other threads:[~2008-07-31 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 13:08 [patch 0/4] vfs: trivial cleanups Miklos Szeredi
2008-07-30 13:08 ` [patch 1/4] splice: fix comment Miklos Szeredi
2008-07-30 13:08 ` [patch 2/4] vfs: filp is never NULL in do_generic_file_read() Miklos Szeredi
2008-07-31 7:19 ` KOSAKI Motohiro [this message]
2008-07-31 7:30 ` Li Zefan
2008-07-30 13:08 ` [patch 3/4] vfs: remove unused nameidata argument of may_create() Miklos Szeredi
2008-07-30 13:08 ` [patch 4/4] vfs: create file_truncate() helper Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731161554.3C84.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®