* [PATCH -tip] x86: apic - use SET_APIC_DEST_FIELD macro
@ 2008-07-30 15:50 Cyrill Gorcunov
0 siblings, 0 replies; only message in thread
From: Cyrill Gorcunov @ 2008-07-30 15:50 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, Thomas Gleixner, LKML, Maciej W. Rozycki
Use predefined macro instead of hardcoded bit shifting
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
I'm on really sloooow gprs connection so fetching replies not
that often and if there is some inconvenience with this patch
i'll not answer fast, sorry.
Index: linux-2.6.git/arch/x86/kernel/apic_64.c
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic_64.c 2008-07-24 23:16:04.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/apic_64.c 2008-07-24 23:20:56.000000000 +0400
@@ -150,7 +150,7 @@ u32 safe_xapic_wait_icr_idle(void)
void xapic_icr_write(u32 low, u32 id)
{
- apic_write(APIC_ICR2, id << 24);
+ apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(id));
apic_write(APIC_ICR, low);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-01 14:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-30 15:50 [PATCH -tip] x86: apic - use SET_APIC_DEST_FIELD macro Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome