Re: kernel bug (null pointer) in 2.6.27-rc1

Re: kernel bug (null pointer) in 2.6.27-rc1

[c4p7n1]

> On Di, 29 Jul 2008, Ryan Hope wrote:
> > This patch fixes this issue, it fixed it for me:
> 
> Thanks, although that ...
> 
> > -static SYSDEV_ATTR(sched_smt_power_savings, 0644,
> sched_smt_power_savings_show,
> > -		   sched_smt_power_savings_store);
> > +static SYSDEV_CLASS_ATTR(sched_smt_power_savings, 0644,
> > +                    sched_smt_power_savings_show,
> >  #endif
> 
> Seems to be bogus and produced a
> 	kernel/sched.c:9137:1: error: unterminated argument list
> 	invoking macro "SYSDEV_CLASS_ATTR"
> Hopefully not in the kernel ...
> 
Reverting "sysdev: Pass the attribute to the low level sysdev show/store function"
4a0b2b4dbe1335b8b9886ba3dc85a145d5d938ed
helps here.

Martin Capitanio

kernel bug (null pointer) in 2.6.27-rc1

[Norbert Preining]

Hi all,

(pleace Cc)

Got that just now ...

BUG: unable to handle kernel NULL pointer dereference at 00000002
IP: [<c011bad5>] sched_mc_power_savings_store+0x0/0x2c
*pde = 00000000 
Oops: 0000 [#1] PREEMPT SMP 
Modules linked in: binfmt_misc nls_utf8 fuse dm_crypt dm_mod kvm_intel kvm coretemp tifm_7xx1 gspca_vc032x tifm_core gspca_main nsc_ircc joydev iwl3945 videodev v4l1_compat rfkill mac80211 irda crc_ccitt firewire_ohci firewire_core crc_itu_t

Pid: 4144, comm: sched-powersave Not tainted (2.6.27-rc1 #1)
EIP: 0060:[<c011bad5>] EFLAGS: 00010282 CPU: 0
EIP is at sched_mc_power_savings_store+0x0/0x2c
EAX: c0434498 EBX: c011bad5 ECX: 00000002 EDX: e9135000
ESI: c04344bc EDI: e9135000 EBP: c04344bc ESP: e9133f48
 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process sched-powersave (pid: 4144, ti=e9132000 task=f7934810 task.ti=e9132000)
Stack: c02300db c04341f8 f781fd1c f7e25400 c0195442 00000002 0849e408 e90784c0 
       f7e25414 c04341f8 00000002 e90784c0 c0195392 0849e408 c016433a e9133fa0 
       e90784c0 fffffff7 0849e408 e9132000 c016442a e9133fa0 00000000 00000000 
Call Trace:
 [<c02300db>] sysdev_class_store+0x1e/0x22
 [<c0195442>] sysfs_write_file+0xb0/0xdd
 [<c0195392>] sysfs_write_file+0x0/0xdd
 [<c016433a>] vfs_write+0x7e/0xd6
 [<c016442a>] sys_write+0x3c/0x63
 [<c0102dfe>] syscall_call+0x7/0xb
 [<c0350000>] tg3_init_one+0xaf2/0x1010
 =======================
Code: c0 c3 31 c0 31 c9 31 d2 e8 bb fd ff ff b8 01 00 00 00 c3 e8 ce 4d 00 00 31 c0 31 c9 31 d2 e8 a5 fd ff ff e8 22 4f 00 00 31 c0 c3 <8a> 09 ba ea ff ff ff 8d 41 d0 3c 01 77 1b 31 c0 80 f9 31 0f 94 
EIP: [<c011bad5>] sched_mc_power_savings_store+0x0/0x2c SS:ESP 0068:e9133f48
---[ end trace f43d02115764e57e ]---


kernel config and all other if one needs it.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
`That young girl is one of the least benightedly
unintelligent organic life forms it has been my profound
lack of pleasure not to be able to avoid meeting.'
                 --- Marvin's first ever compliment about anybody.
                 --- Douglas Adams, The Hitchhikers Guide to the Galaxy

Re: kernel bug (null pointer) in 2.6.27-rc1

[Ryan Hope]

This patch fixes this issue, it fixed it for me:

diff --git a/kernel/sched.c b/kernel/sched.c
index 3ba1199..d757da7 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7713,35 +7713,34 @@ static ssize_t sched_power_savings_store(const
char *buf, size_t count, int smt)
 }

 #ifdef CONFIG_SCHED_MC
-static ssize_t sched_mc_power_savings_show(struct sys_device *dev,
-				struct sysdev_attribute *attr, char *page)
+static ssize_t sched_mc_power_savings_show(struct sysdev_class *class,
+                                            char *page)
 {
 	return sprintf(page, "%u\n", sched_mc_power_savings);
 }
-static ssize_t sched_mc_power_savings_store(struct sys_device *dev,
-					    struct sysdev_attribute *attr,
+static ssize_t sched_mc_power_savings_store(struct sysdev_class *class,
 					    const char *buf, size_t count)
 {
 	return sched_power_savings_store(buf, count, 0);
 }
-static SYSDEV_ATTR(sched_mc_power_savings, 0644, sched_mc_power_savings_show,
-		   sched_mc_power_savings_store);
+static SYSDEV_CLASS_ATTR(sched_mc_power_savings, 0644,
+                          sched_mc_power_savings_show,
+                          sched_mc_power_savings_store);
 #endif

 #ifdef CONFIG_SCHED_SMT
-static ssize_t sched_smt_power_savings_show(struct sys_device *dev,
-				struct sysdev_attribute *attr, char *page)
+static ssize_t sched_smt_power_savings_show(struct sysdev_class *dev,
+                                             char *page)
 {
 	return sprintf(page, "%u\n", sched_smt_power_savings);
 }
-static ssize_t sched_smt_power_savings_store(struct sys_device *dev,
-					     struct sysdev_attribute *attr,
+static ssize_t sched_smt_power_savings_store(struct sysdev_class *dev,
 					     const char *buf, size_t count)
 {
 	return sched_power_savings_store(buf, count, 1);
 }
-static SYSDEV_ATTR(sched_smt_power_savings, 0644, sched_smt_power_savings_show,
-		   sched_smt_power_savings_store);
+static SYSDEV_CLASS_ATTR(sched_smt_power_savings, 0644,
+                    sched_smt_power_savings_show,
 #endif

 int sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)

On Tue, Jul 29, 2008 at 5:54 PM, Norbert Preining <preining@logic.at> wrote:
> Hi all,
>
> (pleace Cc)
>
> Got that just now ...
>
> BUG: unable to handle kernel NULL pointer dereference at 00000002
> IP: [<c011bad5>] sched_mc_power_savings_store+0x0/0x2c
> *pde = 00000000
> Oops: 0000 [#1] PREEMPT SMP
> Modules linked in: binfmt_misc nls_utf8 fuse dm_crypt dm_mod kvm_intel kvm coretemp tifm_7xx1 gspca_vc032x tifm_core gspca_main nsc_ircc joydev iwl3945 videodev v4l1_compat rfkill mac80211 irda crc_ccitt firewire_ohci firewire_core crc_itu_t
>
> Pid: 4144, comm: sched-powersave Not tainted (2.6.27-rc1 #1)
> EIP: 0060:[<c011bad5>] EFLAGS: 00010282 CPU: 0
> EIP is at sched_mc_power_savings_store+0x0/0x2c
> EAX: c0434498 EBX: c011bad5 ECX: 00000002 EDX: e9135000
> ESI: c04344bc EDI: e9135000 EBP: c04344bc ESP: e9133f48
>  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> Process sched-powersave (pid: 4144, ti=e9132000 task=f7934810 task.ti=e9132000)
> Stack: c02300db c04341f8 f781fd1c f7e25400 c0195442 00000002 0849e408 e90784c0
>       f7e25414 c04341f8 00000002 e90784c0 c0195392 0849e408 c016433a e9133fa0
>       e90784c0 fffffff7 0849e408 e9132000 c016442a e9133fa0 00000000 00000000
> Call Trace:
>  [<c02300db>] sysdev_class_store+0x1e/0x22
>  [<c0195442>] sysfs_write_file+0xb0/0xdd
>  [<c0195392>] sysfs_write_file+0x0/0xdd
>  [<c016433a>] vfs_write+0x7e/0xd6
>  [<c016442a>] sys_write+0x3c/0x63
>  [<c0102dfe>] syscall_call+0x7/0xb
>  [<c0350000>] tg3_init_one+0xaf2/0x1010
>  =======================
> Code: c0 c3 31 c0 31 c9 31 d2 e8 bb fd ff ff b8 01 00 00 00 c3 e8 ce 4d 00 00 31 c0 31 c9 31 d2 e8 a5 fd ff ff e8 22 4f 00 00 31 c0 c3 <8a> 09 ba ea ff ff ff 8d 41 d0 3c 01 77 1b 31 c0 80 f9 31 0f 94
> EIP: [<c011bad5>] sched_mc_power_savings_store+0x0/0x2c SS:ESP 0068:e9133f48
> ---[ end trace f43d02115764e57e ]---
>
>
> kernel config and all other if one needs it.
>
> Best wishes
>
> Norbert
>
> -------------------------------------------------------------------------------
> Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
> Debian Developer <preining@debian.org>                         Debian TeX Group
> gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
> -------------------------------------------------------------------------------
> `That young girl is one of the least benightedly
> unintelligent organic life forms it has been my profound
> lack of pleasure not to be able to avoid meeting.'
>                 --- Marvin's first ever compliment about anybody.
>                 --- Douglas Adams, The Hitchhikers Guide to the Galaxy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: kernel bug (null pointer) in 2.6.27-rc1

[Norbert Preining]

On Di, 29 Jul 2008, Ryan Hope wrote:
> This patch fixes this issue, it fixed it for me:

Thanks, although that ...

> -static SYSDEV_ATTR(sched_smt_power_savings, 0644, sched_smt_power_savings_show,
> -		   sched_smt_power_savings_store);
> +static SYSDEV_CLASS_ATTR(sched_smt_power_savings, 0644,
> +                    sched_smt_power_savings_show,
>  #endif

Seems to be bogus and produced a
	kernel/sched.c:9137:1: error: unterminated argument list
	invoking macro "SYSDEV_CLASS_ATTR"
Hopefully not in the kernel ...

Rebooting soon ...

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
TILLICOULTRY (n.)
The man-to-man chumminess adopted by an employer as a prelude for
telling an employee that he's going to have to let him go.
			--- Douglas Adams, The Meaning of Liff