From: Jonathan Corbet <corbet@lwn.net>
To: Alex Chiang <achiang@hp.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Amanda McPherson <amanda@amcpherson.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH, RFC] A development process document
Date: Thu, 31 Jul 2008 10:17:38 -0600 [thread overview]
Message-ID: <20080731101738.1bf4281c@bike.lwn.net> (raw)
In-Reply-To: <20080731062305.GA18070@ldl.fc.hp.com>
On Thu, 31 Jul 2008 00:23:05 -0600
Alex Chiang <achiang@hp.com> wrote:
> Overall, a great document, as expected from you. I've replied with
> "content" comments below.
I've applied most of them, thanks.
> But it occurs to me that sending "style" comments to the editor of
> LWN is something akin to, well, some combination of Prometheus,
> Icarus, ravenous vultures, rabid penguins, and telling Linus that
> his choice of $EDITOR sucks, which is to say, "unwise".
Naw, English always needs debugging too.
> You've got url reference for some quotes but not all. Would it be
> possible to track them all down? Sorry for asking for all the extra
> work, but I think the references are useful, especially if the
> motivated reader actually visits said reference and gets all sides of
> the story.
I'll see what I can do. Some of the older ones are kind of hard to find.
> > +Patches must be prepared against a specific version of the
> > kernel. As a +general rule, a patch should be based on the current
> > mainline as found in +Linus's git tree. It may become necessary to
> > make versions against -mm,
> ^^^^^^^
> Hm, is this the new recommended style? Grammar school taught me that
> it should be "Linus'" but I've noticed a gradually changing but
> inconsistently applied new school style.
I actually researched that a while back. The rule, as far as I can tell
(and to the extent that English has real rules) is that the trailing "s" is
elided only when making a possessive of a plural noun. "Linus", being very
much a unique, singular entity, needs to be "Linus's" in the possessive
form.
> > +If you have a significant series of patches, it is customary to
> > send an +introductory description as part zero. In general, the
> > second and
>
> This directly conflicts with akpm's advice:
>
> http://www.zipworld.com.au/~akpm/linux/patches/stuff/tpp.txt
>
> Section 6(b).
Interesting; Andrew didn't mention that in his review. I think the intro
postings can be very useful in understanding a patch series as a whole.
Maybe I'll put in something about how anything which should be in the
changelogs needs to go with the actual patches.
Thanks,
jon
next prev parent reply other threads:[~2008-07-31 16:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:30 Jonathan Corbet
2008-07-30 7:15 ` Andrew Morton
2008-07-30 18:05 ` Jonathan Corbet
2008-07-30 11:09 ` Jiri Kosina
2008-07-30 16:05 ` Takashi Iwai
2008-07-30 20:56 ` Jonathan Corbet
2008-07-30 21:30 ` Roland Dreier
2008-07-30 21:38 ` Jiri Kosina
2008-07-31 6:23 ` Alex Chiang
2008-07-31 16:17 ` Jonathan Corbet [this message]
2008-07-31 17:49 ` Daniel Barkalow
2008-07-31 17:57 ` Randy.Dunlap
2008-08-01 10:35 ` Stefan Richter
2008-08-01 16:52 ` Daniel Barkalow
2008-07-31 12:22 ` Jochen Voß
2008-07-31 16:30 ` Jonathan Corbet
2008-07-31 23:45 ` Jake Edge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731101738.1bf4281c@bike.lwn.net \
--to=corbet@lwn.net \
--cc=achiang@hp.com \
--cc=akpm@linux-foundation.org \
--cc=amanda@amcpherson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®