From: "Jochen Voß" <jochen.voss@googlemail.com>
To: "Jonathan Corbet" <corbet@lwn.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Amanda McPherson" <amanda@amcpherson.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH, RFC] A development process document
Date: Thu, 31 Jul 2008 13:22:17 +0100 [thread overview]
Message-ID: <ef1cd66f0807310522j67d10fccm3ccc2cb7ebe51908@mail.gmail.com> (raw)
In-Reply-To: <20080729143015.0f79cf37@bike.lwn.net>
Hi Jon,
Some more minor issues (disclaimer: I am not a native speaker of English).
2008/7/29 Jonathan Corbet <corbet@lwn.net>:
> +One of the most compelling features of Linux is that it is accessible to
> +these developers; anybody with the requisite skills can improve Linux and
> +influence the direction of its development. Proprietary products cannot
> +offer this kind of openness, which is a characteristic of the free software
> +process. But, if anything, the kernel is open even than most other free
> +software projects. ...
This last sentence looks strange to me. Maybe a "more" is missing somehow?
[ I sent this one before, but forgot the proper Cc:s. Sorry about that. ]
> +Years of experience with the kernel development community has taught a
> +clear lesson: ...
"have taught"?
> +5.5: SENDING THE PATCH
Maybe somewhere in this section say something about avoiding HTML
email and attachments?
> + - Signed-off-by: this is a developer's certification that he or she has
> + the right to submit the patch for inclusion into the kernel. It is an
> + agreement to the Developer's Certificate of Origin, the full text of
> + which can be found in SubmittingPatches. Code without a proper signoff
> + cannot be merged into the mainline.
Earlier you prefixed file names with "Documentation/". Maybe do the
same here (and in the following paragraphs) for consistency?
> + - If you are responding to a bug report or a feature request, copy those
> + people as well.
Maybe "the reporters" or similar instead of "those people"?
> +6.1: WORKING WITH REVIEWERS
> +
> +A patch of any significance will result in a number of comments from other
> +developers as they review the code. Working with reviewers can be, for
> +many developers, the most indimidating part of the kernel development
"intimidating"
> +Excessive use of this capability can lead to other problems, though, beyond
> +a simple obsession for the creation of the perfect project history.
> +Rewriting history will rewrite the changes contained in that history,
> +turning a tested (hopefully) kernel tree into an untested one. But, beyond
> +that, developers cannot easily collaborate if they do not have a shared
> +view of the project history; if you rewrite history which other developers
> +have pulled into their repositories, you will make life much more difficult
> +for those developers going forward. ...
Is the "going forward" meant to be there?
I hope this helps,
Jochen
--
http://seehuhn.de/
next prev parent reply other threads:[~2008-07-31 12:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:30 Jonathan Corbet
2008-07-30 7:15 ` Andrew Morton
2008-07-30 18:05 ` Jonathan Corbet
2008-07-30 11:09 ` Jiri Kosina
2008-07-30 16:05 ` Takashi Iwai
2008-07-30 20:56 ` Jonathan Corbet
2008-07-30 21:30 ` Roland Dreier
2008-07-30 21:38 ` Jiri Kosina
2008-07-31 6:23 ` Alex Chiang
2008-07-31 16:17 ` Jonathan Corbet
2008-07-31 17:49 ` Daniel Barkalow
2008-07-31 17:57 ` Randy.Dunlap
2008-08-01 10:35 ` Stefan Richter
2008-08-01 16:52 ` Daniel Barkalow
2008-07-31 12:22 ` Jochen Voß [this message]
2008-07-31 16:30 ` Jonathan Corbet
2008-07-31 23:45 ` Jake Edge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef1cd66f0807310522j67d10fccm3ccc2cb7ebe51908@mail.gmail.com \
--to=jochen.voss@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=amanda@amcpherson.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome