mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
	michael@free-electrons.com, Matt Mackall <mpm@selenic.com>,
	matthew@wil.cx, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [patch 2/4] Configure out file locking features
Date: Thu, 31 Jul 2008 16:53:19 +0300	[thread overview]
Message-ID: <20080731135319.GA20212@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080731093220.969460336@free-electrons.com>

On Thu, Jul 31, 2008 at 11:27:05AM +0200, Thomas Petazzoni wrote:
> This patch adds the CONFIG_FILE_LOCKING option which allows to remove
> support for advisory locks. With this patch enabled, the flock()
> system call, the F_GETLK, F_SETLK and F_SETLKW operations of fcntl()
> and NFS support are disabled. These features are not necessarly needed
> on embedded systems. It allows to save ~11 Kb of kernel code and data:
> 
>    text	   data	    bss	    dec	    hex	filename
> 1125436	 118764	 212992	1457192	 163c28	vmlinux.old
> 1114299	 118564	 212992	1445855	 160fdf	vmlinux
>  -11137    -200       0  -11337   -2C49 +/-
> 
> This patch has originally been written by Matt Mackall
> <mpm@selenic.com>, and is part of the Linux Tiny project.
>...

As I've already said in the past I'm personally not a huge fan of these 
patches, but if it brings advantages in real-life situations it's hard
to argue against it.

In which use cases can users safely disable this option, and on what 
devices have you verified that CONFIG_FILE_LOCKING=n kernels actually 
work in practice?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-07-31 13:54 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  9:27 [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices Thomas Petazzoni
2008-07-31  9:27 ` [patch 1/4] Configure out AIO support Thomas Petazzoni
2008-07-31 10:09   ` Bernhard Fischer
2008-07-31 10:12     ` Adrian Bunk
2008-07-31 22:42       ` Bernhard Fischer
2008-08-05 18:15         ` Adrian Bunk
2008-08-05 18:26           ` Jamie Lokier
2008-08-05 18:36             ` Bernhard Fischer
2008-07-31  9:27 ` [patch 2/4] Configure out file locking features Thomas Petazzoni
2008-07-31 13:53   ` Adrian Bunk [this message]
2008-07-31 14:20     ` Thomas Petazzoni
2008-07-31 15:37       ` Adrian Bunk
2008-07-31 16:26         ` Thomas Petazzoni
2008-07-31 16:49           ` Adrian Bunk
2008-07-31 16:57             ` David Woodhouse
2008-07-31 17:32             ` Tim Bird
2008-07-31 18:12               ` Robert Schwebel
2008-07-31 19:31                 ` Adrian Bunk
2008-08-01  7:28                   ` Robert Schwebel
2008-07-31 19:16               ` Adrian Bunk
2008-07-31 20:37                 ` Tim Bird
2008-08-02 16:38   ` J. Bruce Fields
2008-08-04 13:52     ` Thomas Petazzoni
2008-08-04 18:16       ` J. Bruce Fields
2008-08-04 18:24         ` Tim Bird
2008-08-04 18:25           ` J. Bruce Fields
2008-08-04 18:54             ` Matt Mackall
2008-08-04 19:42               ` J. Bruce Fields
2008-08-04 22:32             ` Tim Bird
2008-08-06 13:12         ` Thomas Petazzoni
2008-08-07 22:55           ` J. Bruce Fields
2008-07-31  9:27 ` [patch 3/4] Configure out ethtool support Thomas Petazzoni
2008-07-31 10:40   ` Ben Hutchings
2008-07-31 10:49     ` David Miller
2008-07-31 10:54       ` David Woodhouse
2008-07-31 10:57         ` David Miller
2008-07-31 10:42   ` David Woodhouse
2008-07-31 10:51     ` David Miller
2008-07-31 11:29       ` David Woodhouse
2008-07-31 11:33         ` David Miller
2008-07-31 11:46           ` David Woodhouse
2008-07-31 11:50             ` David Miller
2008-07-31 15:58             ` Adrian Bunk
2008-07-31 16:35               ` Thomas Petazzoni
2008-07-31  9:27 ` [patch 4/4] Configure out IGMP support Thomas Petazzoni
2008-08-01 19:41   ` David Woodhouse
2008-08-04 12:48     ` Thomas Petazzoni
2008-08-04 12:53       ` Adrian Bunk
2008-08-04 13:53       ` David Woodhouse
2008-07-31  9:40 ` [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices David Miller
2008-07-31  9:51   ` David Woodhouse
2008-07-31  9:55     ` David Miller
2008-07-31  9:59       ` David Woodhouse
2008-07-31 10:02         ` David Miller
2008-07-31 10:15           ` David Woodhouse
2008-07-31 10:25             ` David Miller
2008-07-31 17:59               ` Tim Bird
2008-07-31 18:50                 ` [patch 0/4] [resend] Add configuration options to disable features Ulrich Teichert
2008-07-31 19:46                   ` Josh Boyer
2008-07-31 19:55                     ` David Woodhouse
2008-08-01  7:17                     ` Robert Schwebel
2008-08-01 19:15                     ` Linus Torvalds
2008-08-01 19:47                       ` David Woodhouse
2008-07-31 16:42       ` [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices Tim Bird
2008-07-31 17:20         ` Tim Bird
     [not found] <20080729154520.728594017@free-electrons.com>
     [not found] ` <20080729154747.872888047@free-electrons.com>
2008-07-29 18:17   ` [patch 2/4] Configure out file locking features Matthew Wilcox
2008-07-29 18:57     ` Matt Mackall
2008-07-29 20:00       ` Jamie Lokier
2008-07-30 14:27     ` Adrian Bunk
2008-07-30 15:40       ` Thomas Petazzoni
2008-07-31  6:27         ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731135319.GA20212@cs181140183.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=michael@free-electrons.com \
    --cc=mpm@selenic.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®