From: Adrian Bunk <bunk@kernel.org>
To: Tim Bird <tim.bird@am.sony.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
michael@free-electrons.com, Matt Mackall <mpm@selenic.com>,
matthew@wil.cx, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [patch 2/4] Configure out file locking features
Date: Thu, 31 Jul 2008 22:16:50 +0300 [thread overview]
Message-ID: <20080731191650.GA23516@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <4891F724.3030406@am.sony.com>
On Thu, Jul 31, 2008 at 10:32:20AM -0700, Tim Bird wrote:
> Adrian Bunk wrote:
> > And for embedded systems with which applications is it 100% safe to
> > disable this option?
>
> Sony's digital cameras.
>
> This option *is* disabled in the kernel for (most) Sony digital cameras.
> Those digital cameras have the kernel, busybox, a custom C library,
> and one proprietary application. The application does not use
> flock() (or AIO, or ethtool or multi-cast)
>
> These cameras were heavily tested, and are shipping now. I can't
> make any guarantees for other developers, but those of us who
> are careful about our application development would like the option
> to eliminate completely unused features from the kernel. (And
> the C library, but that's a different issue.)
>
> > And don't answer "doesn't use flock()", I want a real-life example of a
> > device where you could guarantee a developer that disabling this option
> > in his product would be safe.
>
> I'm not sure why a guarantee is required that other developers
> use this option safely. Maybe this is a point of disconnect between
> embedded folks and non-embedded folks. We're accustomed to making
> tradeoff decisions that only affect our product, and which
> we take full responsibility for testing.
Thanks. That's quite different from Thomas' "In practice, I only tested
a CONFIG_FILE_LOCKING=n kernel with a basic Busybox under Qemu." and
addresses my concerns.
In case I didn't express myself clearly:
I was not interested in guarantees for random developers but in seeing
some reasonable use case for a real device.
> If warnings or support avoidance for the general population using
> such config options is the issue, I think that David Woodhouse's
> suggestion that such things could taint the kernel is an interesting
> idea. Maybe have we could have an "unsafe-config" taint flag?
A CONFIG_EMBEDDED=y flag?
> I should add that I am sympathetic with the larger issue you raise
> about nibbling at the bottom with patches that only address a
> few KB of the problem, while the size continues to build (to an
> even greater degree) with each release. My response is that I agree
> with you on the nibbling bit, but probably just at a different
> level of KB savings.
>
> That is, I presume you'd be OK with something that saved 100K or
> even 20K, but balk at bit at these patches, which save 10k or less.
> My threshold is lower (probably down to about 5K, so these are
> pretty close to the bubble), but even I wouldn't recommend
> applying anything much below that. We've already started
> considering to drop some linux-tiny patches that just don't save
> enough to warrant continued maintenance.
It's not only about limits, I also have a general dislike for the
"add more config options" approach.
I get your point why it brings advantages in some cases, but if you are
looking for a cheerleader it won't be me. ;-)
> -- Tim
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-07-31 19:17 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 9:27 [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices Thomas Petazzoni
2008-07-31 9:27 ` [patch 1/4] Configure out AIO support Thomas Petazzoni
2008-07-31 10:09 ` Bernhard Fischer
2008-07-31 10:12 ` Adrian Bunk
2008-07-31 22:42 ` Bernhard Fischer
2008-08-05 18:15 ` Adrian Bunk
2008-08-05 18:26 ` Jamie Lokier
2008-08-05 18:36 ` Bernhard Fischer
2008-07-31 9:27 ` [patch 2/4] Configure out file locking features Thomas Petazzoni
2008-07-31 13:53 ` Adrian Bunk
2008-07-31 14:20 ` Thomas Petazzoni
2008-07-31 15:37 ` Adrian Bunk
2008-07-31 16:26 ` Thomas Petazzoni
2008-07-31 16:49 ` Adrian Bunk
2008-07-31 16:57 ` David Woodhouse
2008-07-31 17:32 ` Tim Bird
2008-07-31 18:12 ` Robert Schwebel
2008-07-31 19:31 ` Adrian Bunk
2008-08-01 7:28 ` Robert Schwebel
2008-07-31 19:16 ` Adrian Bunk [this message]
2008-07-31 20:37 ` Tim Bird
2008-08-02 16:38 ` J. Bruce Fields
2008-08-04 13:52 ` Thomas Petazzoni
2008-08-04 18:16 ` J. Bruce Fields
2008-08-04 18:24 ` Tim Bird
2008-08-04 18:25 ` J. Bruce Fields
2008-08-04 18:54 ` Matt Mackall
2008-08-04 19:42 ` J. Bruce Fields
2008-08-04 22:32 ` Tim Bird
2008-08-06 13:12 ` Thomas Petazzoni
2008-08-07 22:55 ` J. Bruce Fields
2008-07-31 9:27 ` [patch 3/4] Configure out ethtool support Thomas Petazzoni
2008-07-31 10:40 ` Ben Hutchings
2008-07-31 10:49 ` David Miller
2008-07-31 10:54 ` David Woodhouse
2008-07-31 10:57 ` David Miller
2008-07-31 10:42 ` David Woodhouse
2008-07-31 10:51 ` David Miller
2008-07-31 11:29 ` David Woodhouse
2008-07-31 11:33 ` David Miller
2008-07-31 11:46 ` David Woodhouse
2008-07-31 11:50 ` David Miller
2008-07-31 15:58 ` Adrian Bunk
2008-07-31 16:35 ` Thomas Petazzoni
2008-07-31 9:27 ` [patch 4/4] Configure out IGMP support Thomas Petazzoni
2008-08-01 19:41 ` David Woodhouse
2008-08-04 12:48 ` Thomas Petazzoni
2008-08-04 12:53 ` Adrian Bunk
2008-08-04 13:53 ` David Woodhouse
2008-07-31 9:40 ` [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices David Miller
2008-07-31 9:51 ` David Woodhouse
2008-07-31 9:55 ` David Miller
2008-07-31 9:59 ` David Woodhouse
2008-07-31 10:02 ` David Miller
2008-07-31 10:15 ` David Woodhouse
2008-07-31 10:25 ` David Miller
2008-07-31 17:59 ` Tim Bird
2008-07-31 18:50 ` [patch 0/4] [resend] Add configuration options to disable features Ulrich Teichert
2008-07-31 19:46 ` Josh Boyer
2008-07-31 19:55 ` David Woodhouse
2008-08-01 7:17 ` Robert Schwebel
2008-08-01 19:15 ` Linus Torvalds
2008-08-01 19:47 ` David Woodhouse
2008-07-31 16:42 ` [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices Tim Bird
2008-07-31 17:20 ` Tim Bird
[not found] <20080729154520.728594017@free-electrons.com>
[not found] ` <20080729154747.872888047@free-electrons.com>
2008-07-29 18:17 ` [patch 2/4] Configure out file locking features Matthew Wilcox
2008-07-29 18:57 ` Matt Mackall
2008-07-29 20:00 ` Jamie Lokier
2008-07-30 14:27 ` Adrian Bunk
2008-07-30 15:40 ` Thomas Petazzoni
2008-07-31 6:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080731191650.GA23516@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michael@free-electrons.com \
--cc=mpm@selenic.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®