mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Luotao Fu <l.fu@pengutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	RT <linux-rt-users@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue?
Date: Fri, 1 Aug 2008 14:09:13 -0700	[thread overview]
Message-ID: <20080801210913.GC14851@linux.vnet.ibm.com> (raw)
In-Reply-To: <486B607F.9040903@grandegger.com>

On Wed, Jul 02, 2008 at 01:03:27PM +0200, Wolfgang Grandegger wrote:
> Wolfgang Grandegger wrote:
>> Steven Rostedt wrote:
>> There seems to be something in trace_mark() keeping latency low:
>>   http://lxr.linux.no/linux+v2.6.24.4/include/linux/marker.h#L52
>> I will follow your suggestions.
>
> I removed all "likely" and "unlikely" macros, but the latencies did not 
> improve. Then I added
>
> 	preempt_disable();
> 	preempt_enable();
>
> at the two locations mentioned above, like trace_mark() does,  and disabled 
> CONFIG_RCU_TRACE. That helped to keep the latencies low, and it did for 
> 2.6.25.8-rt7 as well. As I see it, adding preemption points seem to prevent 
> high latencies.

Interesting.  Perhaps a preempt_enable_no_resched() somewhere that
should be preempt_enable()?

							Thanx, Paul

  parent reply	other threads:[~2008-08-01 21:11 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  4:27 2.6.24-rc8-rt1 Steven Rostedt
2008-01-17  5:26 ` 2.6.24-rc8-rt1 Mark Knecht
2008-01-17 10:13 ` 2.6.24-rc8-rt1 Wolfgang Grandegger
2008-01-17 12:46   ` 2.6.24-rc8-rt1 Luotao Fu
2008-01-17 16:17   ` 2.6.24-rc8-rt1 Daniel Walker
2008-01-17 18:17     ` 2.6.24-rc8-rt1 Wolfgang Grandegger
2008-01-17 18:30       ` 2.6.24-rc8-rt1 Daniel Walker
2008-01-17 18:44         ` 2.6.24-rc8-rt1 Steven Rostedt
2008-01-17 18:45         ` 2.6.24-rc8-rt1 Steven Rostedt
2008-01-17 20:01           ` 2.6.24-rc8-rt1 Wolfgang Grandegger
2008-01-17 18:46         ` 2.6.24-rc8-rt1 Wolfgang Grandegger
2008-01-17 21:11   ` 2.6.24-rc8-rt1 Robert Schwebel
2008-01-17 21:36     ` 2.6.24-rc8-rt1 Wolfgang Grandegger
2008-01-23 14:53   ` 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc Luotao Fu
2008-01-23 15:50     ` Daniel Walker
2008-01-23 16:36     ` Wolfgang Grandegger
2008-01-24 10:53       ` Wolfgang Grandegger
2008-01-28 15:11       ` Luotao Fu
2008-01-28 15:38         ` Wolfgang Grandegger
2008-01-29 12:13           ` 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue? Luotao Fu
2008-01-29 13:38             ` Wolfgang Grandegger
2008-01-30  1:07               ` Paul E. McKenney
2008-01-30  8:18                 ` Wolfgang Grandegger
2008-01-30 10:22                   ` Paul E. McKenney
2008-01-30 10:45                     ` Wolfgang Grandegger
2008-01-30 10:57                       ` Paul E. McKenney
2008-01-30 11:15                         ` Luotao Fu
2008-07-01 14:27                           ` Wolfgang Grandegger
2008-07-01 15:11                             ` Steven Rostedt
2008-07-01 16:11                               ` Wolfgang Grandegger
2008-07-01 21:11                                 ` Luotao Fu
2008-07-02 11:03                                 ` Wolfgang Grandegger
2008-07-06  0:42                                   ` Steven Rostedt
2008-07-06  9:41                                     ` Wolfgang Grandegger
2008-07-08 15:08                                       ` Luotao Fu
2008-07-08 19:43                                         ` Wolfgang Grandegger
2008-07-09 12:53                                           ` Luotao Fu
2008-07-09 13:15                                             ` Wolfgang Grandegger
2008-07-09 14:52                                               ` Luotao Fu
2008-07-10  7:50                                                 ` Wolfgang Grandegger
2008-08-01 21:09                                                   ` Paul E. McKenney
2008-08-01 21:09                                   ` Paul E. McKenney [this message]
2008-08-05 15:40                                     ` Wolfgang Grandegger
2008-07-02  8:09                               ` Wolfgang Grandegger
2008-07-06  0:39                                 ` Steven Rostedt
2008-07-06  9:34                                   ` Wolfgang Grandegger
2008-01-30 11:22                         ` Wolfgang Grandegger
2008-01-17 19:57 ` 2.6.24-rc8-rt1 Mariusz Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080801210913.GC14851@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=l.fu@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome