mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracehook: kerneldoc fix
Date: Mon, 4 Aug 2008 14:00:30 -0700	[thread overview]
Message-ID: <20080804140030.b1964c50.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080804205601.4C6ED154252@magilla.localdomain>

On Mon,  4 Aug 2008 13:56:01 -0700 (PDT) Roland McGrath wrote:

> My last change to tracehook.h made it confuse the kerneldoc parser.
> Move the #define's before the comment so it's happy again.

Ack.  Thanks for noticing/fixing.

> Signed-off-by: Roland McGrath <roland@redhat.com>
> ---
>  include/linux/tracehook.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
> index 1253283..ab3ef7a 100644
> --- a/include/linux/tracehook.h
> +++ b/include/linux/tracehook.h
> @@ -487,6 +487,9 @@ static inline int tracehook_notify_jctl(int notify, int why)
>  	return notify || (current->ptrace & PT_PTRACED);
>  }
>  
> +#define DEATH_REAP			-1
> +#define DEATH_DELAYED_GROUP_LEADER	-2
> +
>  /**
>   * tracehook_notify_death - task is dead, ready to notify parent
>   * @task:		@current task now exiting
> @@ -501,8 +504,6 @@ static inline int tracehook_notify_jctl(int notify, int why)
>   *
>   * Called with write_lock_irq(&tasklist_lock) held.
>   */
> -#define DEATH_REAP			-1
> -#define DEATH_DELAYED_GROUP_LEADER	-2
>  static inline int tracehook_notify_death(struct task_struct *task,
>  					 void **death_cookie, int group_dead)
>  {
> --

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

      reply	other threads:[~2008-08-04 21:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04 20:56 Roland McGrath
2008-08-04 21:00 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080804140030.b1964c50.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®