mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tracehook: kerneldoc fix
@ 2008-08-04 20:56 Roland McGrath
  2008-08-04 21:00 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2008-08-04 20:56 UTC (permalink / raw)
  To: Andrew Morton, Linus Torvalds; +Cc: linux-kernel

My last change to tracehook.h made it confuse the kerneldoc parser.
Move the #define's before the comment so it's happy again.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 include/linux/tracehook.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
index 1253283..ab3ef7a 100644
--- a/include/linux/tracehook.h
+++ b/include/linux/tracehook.h
@@ -487,6 +487,9 @@ static inline int tracehook_notify_jctl(int notify, int why)
 	return notify || (current->ptrace & PT_PTRACED);
 }
 
+#define DEATH_REAP			-1
+#define DEATH_DELAYED_GROUP_LEADER	-2
+
 /**
  * tracehook_notify_death - task is dead, ready to notify parent
  * @task:		@current task now exiting
@@ -501,8 +504,6 @@ static inline int tracehook_notify_jctl(int notify, int why)
  *
  * Called with write_lock_irq(&tasklist_lock) held.
  */
-#define DEATH_REAP			-1
-#define DEATH_DELAYED_GROUP_LEADER	-2
 static inline int tracehook_notify_death(struct task_struct *task,
 					 void **death_cookie, int group_dead)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] tracehook: kerneldoc fix
  2008-08-04 20:56 [PATCH] tracehook: kerneldoc fix Roland McGrath
@ 2008-08-04 21:00 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2008-08-04 21:00 UTC (permalink / raw)
  To: Roland McGrath; +Cc: Andrew Morton, Linus Torvalds, linux-kernel

On Mon,  4 Aug 2008 13:56:01 -0700 (PDT) Roland McGrath wrote:

> My last change to tracehook.h made it confuse the kerneldoc parser.
> Move the #define's before the comment so it's happy again.

Ack.  Thanks for noticing/fixing.

> Signed-off-by: Roland McGrath <roland@redhat.com>
> ---
>  include/linux/tracehook.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h
> index 1253283..ab3ef7a 100644
> --- a/include/linux/tracehook.h
> +++ b/include/linux/tracehook.h
> @@ -487,6 +487,9 @@ static inline int tracehook_notify_jctl(int notify, int why)
>  	return notify || (current->ptrace & PT_PTRACED);
>  }
>  
> +#define DEATH_REAP			-1
> +#define DEATH_DELAYED_GROUP_LEADER	-2
> +
>  /**
>   * tracehook_notify_death - task is dead, ready to notify parent
>   * @task:		@current task now exiting
> @@ -501,8 +504,6 @@ static inline int tracehook_notify_jctl(int notify, int why)
>   *
>   * Called with write_lock_irq(&tasklist_lock) held.
>   */
> -#define DEATH_REAP			-1
> -#define DEATH_DELAYED_GROUP_LEADER	-2
>  static inline int tracehook_notify_death(struct task_struct *task,
>  					 void **death_cookie, int group_dead)
>  {
> --

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-04 21:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-04 20:56 [PATCH] tracehook: kerneldoc fix Roland McGrath
2008-08-04 21:00 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®