From: Vegard Nossum <vegard.nossum@gmail.com>
To: Bryan Wu <cooloney@kernel.org>
Cc: Julia Lawall <julia@diku.dk>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] blackfin/sram: use 'unsigned long' for irqflags
Date: Wed, 6 Aug 2008 12:58:36 +0200 [thread overview]
Message-ID: <20080806105836.GA2903@localhost.localdomain> (raw)
(Use a wider diff context such as -U10 after the patch has been applied to
see the actual uses of the variables which we change.)
>From 3ef36948a88a968eec1b09859aa251dc6727df4e Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Wed, 6 Aug 2008 12:00:23 +0200
Subject: [PATCH] blackfin/sram: use 'unsigned long' for irqflags
Using just 'unsigned' will make flags an unsigned int. While this is
arguably not an error on blackfin where sizeof(int) == sizeof(long),
the patch is still justified on the grounds of principle.
The patch was generated using the Coccinelle semantic patch framework.
Cc: Julia Lawall <julia@diku.dk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
arch/blackfin/mm/blackfin_sram.c | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/blackfin/mm/blackfin_sram.c b/arch/blackfin/mm/blackfin_sram.c
index 5af3c31..9bc6aed 100644
--- a/arch/blackfin/mm/blackfin_sram.c
+++ b/arch/blackfin/mm/blackfin_sram.c
@@ -379,7 +379,7 @@ EXPORT_SYMBOL(sram_free);
void *l1_data_A_sram_alloc(size_t size)
{
- unsigned flags;
+ unsigned long flags;
void *addr = NULL;
/* add mutex operation */
@@ -402,7 +402,7 @@ EXPORT_SYMBOL(l1_data_A_sram_alloc);
int l1_data_A_sram_free(const void *addr)
{
- unsigned flags;
+ unsigned long flags;
int ret;
/* add mutex operation */
@@ -425,7 +425,7 @@ EXPORT_SYMBOL(l1_data_A_sram_free);
void *l1_data_B_sram_alloc(size_t size)
{
#if L1_DATA_B_LENGTH != 0
- unsigned flags;
+ unsigned long flags;
void *addr;
/* add mutex operation */
@@ -450,7 +450,7 @@ EXPORT_SYMBOL(l1_data_B_sram_alloc);
int l1_data_B_sram_free(const void *addr)
{
#if L1_DATA_B_LENGTH != 0
- unsigned flags;
+ unsigned long flags;
int ret;
/* add mutex operation */
@@ -504,7 +504,7 @@ EXPORT_SYMBOL(l1_data_sram_free);
void *l1_inst_sram_alloc(size_t size)
{
#if L1_CODE_LENGTH != 0
- unsigned flags;
+ unsigned long flags;
void *addr;
/* add mutex operation */
@@ -529,7 +529,7 @@ EXPORT_SYMBOL(l1_inst_sram_alloc);
int l1_inst_sram_free(const void *addr)
{
#if L1_CODE_LENGTH != 0
- unsigned flags;
+ unsigned long flags;
int ret;
/* add mutex operation */
@@ -551,7 +551,7 @@ EXPORT_SYMBOL(l1_inst_sram_free);
/* L1 Scratchpad memory allocate function */
void *l1sram_alloc(size_t size)
{
- unsigned flags;
+ unsigned long flags;
void *addr;
/* add mutex operation */
@@ -569,7 +569,7 @@ void *l1sram_alloc(size_t size)
/* L1 Scratchpad memory allocate function */
void *l1sram_alloc_max(size_t *psize)
{
- unsigned flags;
+ unsigned long flags;
void *addr;
/* add mutex operation */
@@ -587,7 +587,7 @@ void *l1sram_alloc_max(size_t *psize)
/* L1 Scratchpad memory free function */
int l1sram_free(const void *addr)
{
- unsigned flags;
+ unsigned long flags;
int ret;
/* add mutex operation */
@@ -605,7 +605,7 @@ int l1sram_free(const void *addr)
void *l2_sram_alloc(size_t size)
{
#ifdef L2_LENGTH
- unsigned flags;
+ unsigned long flags;
void *addr;
/* add mutex operation */
@@ -641,7 +641,7 @@ EXPORT_SYMBOL(l2_sram_zalloc);
int l2_sram_free(const void *addr)
{
#ifdef L2_LENGTH
- unsigned flags;
+ unsigned long flags;
int ret;
/* add mutex operation */
--
1.5.5.1
next reply other threads:[~2008-08-06 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 10:58 Vegard Nossum [this message]
2008-08-06 11:05 ` Mike Frysinger
2008-08-06 11:28 ` Vegard Nossum
2008-08-06 12:14 ` Mike Frysinger
2008-08-06 12:17 ` Mike Frysinger
2008-08-06 12:21 ` Julia Lawall
2008-08-06 12:52 ` Vegard Nossum
2008-08-06 17:34 ` Mike Frysinger
2008-08-22 13:44 ` Mike Frysinger
2008-08-27 6:56 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806105836.GA2903@localhost.localdomain \
--to=vegard.nossum@gmail.com \
--cc=adobriyan@gmail.com \
--cc=cooloney@kernel.org \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®