mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] m68k/amiserial: fix fallout of tty break handling rework
@ 2008-08-06 20:19 Geert Uytterhoeven
  2008-08-06 22:28 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2008-08-06 20:19 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton
  Cc: Alan Cox, Linux Kernel Development, Linux/m68k

commit 9e98966c7bb94355689478bc84cc3e0c190f977e (tty: rework break handling)
forgot to update one exit point of rs_break() in the Amiga serial driver.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/char/amiserial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/char/amiserial.c
+++ b/drivers/char/amiserial.c
@@ -1254,7 +1254,7 @@ static int rs_break(struct tty_struct *t
 	unsigned long flags;
 
 	if (serial_paranoia_check(info, tty->name, "rs_break"))
-		return;
+		return -EINVAL;
 
 	local_irq_save(flags);
 	if (break_state == -1)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] m68k/amiserial: fix fallout of tty break handling rework
  2008-08-06 20:19 [PATCH] m68k/amiserial: fix fallout of tty break handling rework Geert Uytterhoeven
@ 2008-08-06 22:28 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2008-08-06 22:28 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linus Torvalds, Andrew Morton, Alan Cox,
	Linux Kernel Development, Linux/m68k

On Wed, Aug 06, 2008 at 10:19:39PM +0200, Geert Uytterhoeven wrote:
> commit 9e98966c7bb94355689478bc84cc3e0c190f977e (tty: rework break handling)
> forgot to update one exit point of rs_break() in the Amiga serial driver.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Alan Cox <alan@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-06 22:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-06 20:19 [PATCH] m68k/amiserial: fix fallout of tty break handling rework Geert Uytterhoeven
2008-08-06 22:28 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome