From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: "Yinghai Lu" <yhlu.kernel@gmail.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Dhaval Giani" <dhaval@linux.vnet.ibm.com>,
"Mike Travis" <travis@sgi.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/33] dyn_array and nr_irqs support v4
Date: Thu, 7 Aug 2008 11:12:16 +0100 [thread overview]
Message-ID: <20080807111216.6cfdbeea@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <m18wv9iqn9.fsf@frodo.ebiederm.org>
On Wed, 06 Aug 2008 18:02:18 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:
> Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>
> > A lot of these are range checks so could be replaced by a single
> > valid_irq(irq) test.
>
> Yes. My first impression was that with NR_IRQS dead valid_irq could
> easily become. #define valid_irq(irq) ((irq) != 0)
Not really - there are lots of cases where we sanity check an IRQ passed
from user space or module parameter configuration. So we do actually need
valid_irq(irq) ((irq) > 0 && (irq) < nr_irqs)
[or relevant per arch alternatives]
Alan
next prev parent reply other threads:[~2008-08-07 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <No>
2008-08-06 8:38 ` Yinghai Lu
2008-08-06 8:38 ` [PATCH 01/33] x86: add after_bootmem for 32bit Yinghai Lu
2008-08-06 8:38 ` [PATCH 02/33] x86: remove irq_vectors_limits Yinghai Lu
2008-08-06 17:37 ` [PATCH 00/33] dyn_array and nr_irqs support v4 Eric W. Biederman
2008-08-06 18:29 ` Yinghai Lu
2008-08-06 18:50 ` Yinghai Lu
2008-08-06 20:32 ` Eric W. Biederman
2008-08-06 20:52 ` Yinghai Lu
2008-08-06 20:35 ` Eric W. Biederman
2008-08-06 20:57 ` Yinghai Lu
2008-08-06 23:26 ` Alan Cox
2008-08-07 1:02 ` Eric W. Biederman
2008-08-07 10:12 ` Alan Cox [this message]
2008-08-07 10:51 ` Yinghai Lu
2008-08-07 10:57 ` Alan Cox
2008-08-07 18:12 ` H. Peter Anvin
2008-08-06 8:42 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807111216.6cfdbeea@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®