mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [2.6 patch] fix watchdog/at91rm9200_wdt.c compilation
@ 2008-08-08 15:57 Adrian Bunk
  2008-08-09 10:01 ` Russell King
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-08-08 15:57 UTC (permalink / raw)
  To: Alan Cox, Wim Van Sebroeck; +Cc: rmk, linux-kernel, Andrew Morton

This patch fixes the following compile error:

<--  snip  -->

...
  CC      drivers/watchdog/at91rm9200_wdt.o
at91rm9200_wdt.c:188: error: 'at91_wdt_ioctl' undeclared here (not in a 
make[3]: *** [drivers/watchdog/at91rm9200_wdt.o] Error 1

<--  snip  -->

Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
0cbc8aa3114bc48a868de8cc9a1706b6c81dd3f4 
diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
index 2313f44..09363f1 100644
--- a/drivers/watchdog/at91rm9200_wdt.c
+++ b/drivers/watchdog/at91rm9200_wdt.c
@@ -129,7 +129,7 @@ static struct watchdog_info at91_wdt_info = {
 /*
  * Handle commands from user-space.
  */
-static long at91_wdt_ioct(struct file *file,
+static long at91_wdt_ioctl(struct file *file,
 					unsigned int cmd, unsigned long arg)
 {
 	void __user *argp = (void __user *)arg;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] fix watchdog/at91rm9200_wdt.c compilation
  2008-08-08 15:57 [2.6 patch] fix watchdog/at91rm9200_wdt.c compilation Adrian Bunk
@ 2008-08-09 10:01 ` Russell King
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2008-08-09 10:01 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Alan Cox, Wim Van Sebroeck, linux-kernel, Andrew Morton

On Fri, Aug 08, 2008 at 06:57:45PM +0300, Adrian Bunk wrote:
> This patch fixes the following compile error:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/watchdog/at91rm9200_wdt.o
> at91rm9200_wdt.c:188: error: 'at91_wdt_ioctl' undeclared here (not in a 
> make[3]: *** [drivers/watchdog/at91rm9200_wdt.o] Error 1

Can we please get these fixes to Linus ASAP - this kind and quantity
of breakage should have never made it to Linus' kernel.  (s3c2410_wdt,
at91rm9200_wdt, and wdt285 all broken with trivial compile errors).

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-09 10:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-08 15:57 [2.6 patch] fix watchdog/at91rm9200_wdt.c compilation Adrian Bunk
2008-08-09 10:01 ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome