mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [2.6 patch] fix watchdog/ixp4xx_wdt.c compilation
@ 2008-08-10 11:03 Adrian Bunk
  2008-08-10 11:41 ` Russell King
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-08-10 11:03 UTC (permalink / raw)
  To: Alan Cox, Wim Van Sebroeck; +Cc: rmk, linux-kernel, Andrew Morton

This patch fixes the following compile error caused by
commit 20d35f3e50ea7e573f9568b9fce4e98523aaee5d
([WATCHDOG 22/57] ixp4xx_wdt: unlocked_ioctl):

<--  snip  -->

...
  CC      drivers/watchdog/ixp4xx_wdt.o
ixp4xx_wdt.c:32: error: expected '=', ',', ';', 'asm' or '__attribute__' 
ixp4xx_wdt.c: In function 'wdt_enable':
ixp4xx_wdt.c:41: error: 'wdt_lock' undeclared (first use in this 
ixp4xx_wdt.c:41: error: (Each undeclared identifier is reported only 
ixp4xx_wdt.c:41: error: for each function it appears in.)
ixp4xx_wdt.c: In function 'wdt_disable':
ixp4xx_wdt.c:52: error: 'wdt_lock' undeclared (first use in this 
ixp4xx_wdt.c: In function 'ixp4xx_wdt_init':
ixp4xx_wdt.c:186: error: 'wdt_lock' undeclared (first use in this 
make[3]: *** [drivers/watchdog/ixp4xx_wdt.o] Error 1

<--  snip  -->

Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
9ff35bbffb5fb755104fc90825523b9ffa2b14cf 
diff --git a/drivers/watchdog/ixp4xx_wdt.c b/drivers/watchdog/ixp4xx_wdt.c
index 41264a5..8302ef0 100644
--- a/drivers/watchdog/ixp4xx_wdt.c
+++ b/drivers/watchdog/ixp4xx_wdt.c
@@ -29,7 +29,7 @@ static int nowayout = WATCHDOG_NOWAYOUT;
 static int heartbeat = 60;	/* (secs) Default is 1 minute */
 static unsigned long wdt_status;
 static unsigned long boot_status;
-static spin_lock_t wdt_lock;
+static DEFINE_SPINLOCK(wdt_lock);
 
 #define WDT_TICK_RATE (IXP4XX_PERIPHERAL_BUS_CLOCK * 1000000UL)
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] fix watchdog/ixp4xx_wdt.c compilation
  2008-08-10 11:03 [2.6 patch] fix watchdog/ixp4xx_wdt.c compilation Adrian Bunk
@ 2008-08-10 11:41 ` Russell King
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2008-08-10 11:41 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Alan Cox, Wim Van Sebroeck, linux-kernel, Andrew Morton

On Sun, Aug 10, 2008 at 02:03:41PM +0300, Adrian Bunk wrote:
> This patch fixes the following compile error caused by
> commit 20d35f3e50ea7e573f9568b9fce4e98523aaee5d
> ([WATCHDOG 22/57] ixp4xx_wdt: unlocked_ioctl):

Thanks Adrian.

I've merged all these into one big "Fix a pile of broken watchdog drivers"
commit along with the remaining fixes for s3c2410_wdt that were missed
from my patch.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-10 11:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-10 11:03 [2.6 patch] fix watchdog/ixp4xx_wdt.c compilation Adrian Bunk
2008-08-10 11:41 ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®