* [PATCH] security.h: fix build failure
@ 2008-08-17 1:34 Alexander Beregalov
2008-08-17 9:24 ` Ingo Molnar
2008-08-17 12:43 ` James Morris
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Beregalov @ 2008-08-17 1:34 UTC (permalink / raw)
To: dhowells, serue, casey, morgan, viro, jmorris, linux-kernel
From: Alexander Beregalov <a.beregalov@gmail.com>
security.h: fix build failure
include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
include/linux/security.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/security.h b/include/linux/security.h
index 2ee5ecf..80c4d00 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
return cap_ptrace_may_access(child, mode);
}
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
{
return cap_ptrace_traceme(parent);
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] security.h: fix build failure
2008-08-17 1:34 [PATCH] security.h: fix build failure Alexander Beregalov
@ 2008-08-17 9:24 ` Ingo Molnar
2008-08-17 12:43 ` James Morris
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-08-17 9:24 UTC (permalink / raw)
To: Alexander Beregalov
Cc: dhowells, serue, casey, morgan, viro, jmorris, linux-kernel
* Alexander Beregalov <a.beregalov@gmail.com> wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
>
> security.h: fix build failure
>
> include/linux/security.h: In function 'security_ptrace_traceme':
> include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)
i just triggered this too on today's -git with this config:
http://redhat.com/~mingo/misc/config-Sun_Aug_17_11_02_11_CEST_2008.bad
and your fix solves it.
Tested-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security.h: fix build failure
2008-08-17 1:34 [PATCH] security.h: fix build failure Alexander Beregalov
2008-08-17 9:24 ` Ingo Molnar
@ 2008-08-17 12:43 ` James Morris
2008-08-17 13:08 ` [GIT] " James Morris
1 sibling, 1 reply; 4+ messages in thread
From: James Morris @ 2008-08-17 12:43 UTC (permalink / raw)
To: Alexander Beregalov
Cc: David Howells, Serge E. Hallyn, Casey Schaufler, morgan, viro,
linux-kernel, Linus Torvalds
On Sun, 17 Aug 2008, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
>
> security.h: fix build failure
>
> include/linux/security.h: In function 'security_ptrace_traceme':
> include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)
>
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Acked-by: James Morris <jmorris@namei.org>
> ---
>
> include/linux/security.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 2ee5ecf..80c4d00 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
> return cap_ptrace_may_access(child, mode);
> }
>
> -static inline int security_ptrace_traceme(struct task_struct *child)
> +static inline int security_ptrace_traceme(struct task_struct *parent)
> {
> return cap_ptrace_traceme(parent);
> }
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* [GIT] Re: [PATCH] security.h: fix build failure
2008-08-17 12:43 ` James Morris
@ 2008-08-17 13:08 ` James Morris
0 siblings, 0 replies; 4+ messages in thread
From: James Morris @ 2008-08-17 13:08 UTC (permalink / raw)
To: Alexander Beregalov
Cc: David Howells, Serge E. Hallyn, Casey Schaufler, morgan, viro,
linux-kernel, Linus Torvalds
There's a pullable version here:
The following changes since commit
b09c3e3f1710b554348c98e78fbf4a661918779a:
Huang Weiyi (1):
removed unused #include <version.h>
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6 for-linus
Alexander Beregalov (1):
security.h: fix build failure
include/linux/security.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-17 13:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-17 1:34 [PATCH] security.h: fix build failure Alexander Beregalov
2008-08-17 9:24 ` Ingo Molnar
2008-08-17 12:43 ` James Morris
2008-08-17 13:08 ` [GIT] " James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®