From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
jirislaby@gmail.com
Subject: Re: [PATCH 1/3] Char: cyclades, remove bogus iomap
Date: Mon, 18 Aug 2008 14:44:38 -0700 [thread overview]
Message-ID: <20080818144438.e3eab97a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1218731154-32692-1-git-send-email-jirislaby@gmail.com>
On Thu, 14 Aug 2008 18:25:52 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> readl/writel are not expected to accept iomap return value. Replace
> bogus mapping by standard ioremap.
Confused. What's wrong with doing readl(pci_iomap(...))? There are a
fair number of drivers doing this..
next prev parent reply other threads:[~2008-08-18 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 16:25 Jiri Slaby
2008-08-14 16:25 ` [PATCH 2/3] Char: sx, fix io unmapping Jiri Slaby
2008-08-14 16:25 ` [PATCH 3/3] Char: sx, remove bogus iomap Jiri Slaby
2008-08-18 21:44 ` Andrew Morton [this message]
2008-08-18 21:38 ` [PATCH 1/3] Char: cyclades, " Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818144438.e3eab97a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®